Re: RFR: JDK-8049516: sun.security.provider.SeedGenerator throws ArrayIndexOutOfBoundsException

2016-09-20 Thread Jamil Nimeh
Hi Max and Xuelei, thanks for the feedback. On 09/20/2016 07:52 PM, Wang Weijun wrote: On Sep 21, 2016, at 9:58 AM, Xuelei Fan wrote: 359 while (System.nanoTime() - startTime < 25000) { 360 synchronized(this){}; - 361 latch++; + 361 latch = (latch + 1) % Integer.MA

Re: [9]RFR 8136355: CKM_SSL3_KEY_AND_MAC_DERIVE no longer available by default on Solaris 12

2016-09-20 Thread Xuelei Fan
P11TlsKeyMaterialGenerator.java 102-106: There is a bug in the previous code. "&&" should be replaced with "||". - (version < 0x0300) && (version > 0x0302) + (version < 0x0300) || (version > 0x0302) The other two have the same issues. Otherwise, looks fine to me. BTW, if client request to n

Re: RFR: JDK-8049516: sun.security.provider.SeedGenerator throws ArrayIndexOutOfBoundsException

2016-09-20 Thread Wang Weijun
> On Sep 21, 2016, at 9:58 AM, Xuelei Fan wrote: > > 359 while (System.nanoTime() - startTime < 25000) { > 360 synchronized(this){}; > - 361 latch++; > + 361 latch = (latch + 1) % Integer.MAX_VALUE; > 362 } > > This block may be not CPU friendly as it may loop a lar

Re: RFR: JDK-8049516: sun.security.provider.SeedGenerator throws ArrayIndexOutOfBoundsException

2016-09-20 Thread Xuelei Fan
359 while (System.nanoTime() - startTime < 25000) { 360 synchronized(this){}; - 361 latch++; + 361 latch = (latch + 1) % Integer.MAX_VALUE; 362 } This block may be not CPU friendly as it may loop a large amount of times in a very short period (250milli). What's

RFR: JDK-8049516: sun.security.provider.SeedGenerator throws ArrayIndexOutOfBoundsException

2016-09-20 Thread Jamil Nimeh
Hello all, This fixes a bug found in stress testing where on faster CPUs the latch can overflow resulting in a negative array index. The fix avoids the overflow by resetting the latch to 0 when it reaches Integer.MAX_VALUE - 1 and will continue increasing from there. Bug: https://bugs.openj

Re: [9] RFR: 8164591: sun/net/www/protocol/https/HttpsClient/ServerIdentityTest.java failed with SSLHandshakeException

2016-09-20 Thread Artem Smotrakov
Hello, If you don't mind, I moved some common code from SSLSocketTemplate.java to SSLTest.java, so that it can be re-used by other tests. It may help to avoid duplicate code. http://cr.openjdk.java.net/~asmotrak/8164591/webrev.01/ Please take a look. Artem On 09/15/2016 11:49 AM, Artem Sm

RFR(s): 8166378: Missing dependencies in several java/security tests

2016-09-20 Thread Sergei Kovalev
Hello team, Please review very small fix for several regression tests. BugID: https://bugs.openjdk.java.net/browse/JDK-8166378 WebReview: http://cr.openjdk.java.net/~skovalev/8166378/webrev.00 Issue: The tests has no declared dependencies on jdk.security modules. This leads the tests to fail i