RFR: 8165712: Grant permission to read specific properties instead of all to the jdk.crypto.ucrypto module

2016-10-13 Thread Sean Mullan
Please review this fix to only grant the necessary PropertyPermissions to the jdk.crypto.ucrypto module. In UcryptoProvider I also moved the System.getProperty("os.name") inside doPrivileged (just in case permission to read this property has not been granted to the caller) and did some minor r

Re: RFR 8165274: SHA1 certpath constraint check fails with OCSP certificate

2016-10-13 Thread Sean Mullan
On 10/13/2016 01:29 AM, Anthony Scarpino wrote: On 10/12/2016 01:41 PM, Sean Mullan wrote: On 10/12/2016 04:06 PM, Anthony Scarpino wrote: Later in the verify(), AlgorithmChecker needs a TrustAnchor object. In this case, because it's the old method that deploy is using, I have to manufacture a

Code Review Request, JDK-8167680, DTLS implementation bugs

2016-10-13 Thread Xuelei Fan
Hi, Please review the fix for JDK-8167680: http://cr.openjdk.java.net/~xuelei/8167680/webrev.00/ There are a few implementation bugs in JDK. 1. The sequence number is increased by 2 for GCM cipher suites. Both GCM crypto operation and DTLS record use the sequence number. The current implem

Re: [9] RFR 8167371: KeyStoreSpi.engineSetEntry should throw an Exception if password protection alg is specified

2016-10-13 Thread Xuelei Fan
Nice catch! Looks fine to me. Xuelei On 10/13/2016 6:33 PM, Vincent Ryan wrote: Please review this fix to add a check to the default implementation of KeyStore setEntry and getEntry (in KeyStoreSpi). An exception is thrown if a password protection algorithm is specified. An existing test has

[9] RFR 8167371: KeyStoreSpi.engineSetEntry should throw an Exception if password protection alg is specified

2016-10-13 Thread Vincent Ryan
Please review this fix to add a check to the default implementation of KeyStore setEntry and getEntry (in KeyStoreSpi). An exception is thrown if a password protection algorithm is specified. An existing test has been updated to validate the fix. Keystore implementations that support a user-supp