Re: [9] RFR: 8168969: Merge SSLSocketSample and SSLSocketTemplate

2016-11-01 Thread John Jiang
Hi Artem, Thanks for making the template to be used easily. The tests in your patch extend class SSLSocketTemplate, but SSLSocketTemplate looks like an utility class, but not a parent class. For example, test/sun/security/ssl/ServerHandshaker/AnonCipherWithWantClientAuth.java 67 new S

[9] RFR: 8168969: Merge SSLSocketSample and SSLSocketTemplate

2016-11-01 Thread Artem Smotrakov
Hello, Please review the following patch which merges a couple of classes in javax/net/ssl/templates. SSLTest class contains re-usable parts of SSLSocketSample. SSLSocketTemplate class is buggy (tests which follows it may fail intermittently). I basically replaced SSLSocketTemplate with SSLT

[9] RFR: 8168882: keytool doesn't print certificate info if disabled algorithm was used for signing a jar

2016-11-01 Thread Artem Smotrakov
Hello, Please review this small update for keytool. "keytool -printcert -jarfile" doesn't work with jars which were signed with algorithms listed in "jdk.jar.disabledAlgorithms" security property. The patch below resets "jdk.jar.disabledAlgorithms" security property before reading a jar file

RFR(s): 8169002: [TESTBUG] Several java/net/httpclient have undeclared dependency on java.logging module

2016-11-01 Thread Sergei Kovalev
Hello all, Please review a small fix for tests. BugID: https://bugs.openjdk.java.net/browse/JDK-8169002 WebRev: http://cr.openjdk.java.net/~skovalev/8169002/webrev.00/ Issue: Several tests from java/net/httpclient folder have undeclared dependency on java.logging module. This issue leads the t