Re: [9] RFR: 8168882: keytool doesn't print certificate info if disabled algorithm was used for signing a jar

2016-11-03 Thread Artem Smotrakov
Thank you for review Sean. I'll remove the warning then. And I'll update it to reset the security property only if a jar file has been specified. Let me also check how "-printcert -file ..." and "-printcert -sslserver" work. Artem On 11/03/2016 07:27 AM, Wang Weijun wrote: I agree with S

Re: [9] RFR: 8168882: keytool doesn't print certificate info if disabled algorithm was used for signing a jar

2016-11-03 Thread Wang Weijun
I agree with Sean. --Max > On Nov 3, 2016, at 10:00 PM, Sean Mullan wrote: > > You should only unset the jdk.jar.disabledAlgorithms property if a jarfile > has been specified. > > Also, you are printing the warning message for all usages of the -printcert > option, -ssl, etc, which is not co

Re: [9] RFR: 8168882: keytool doesn't print certificate info if disabled algorithm was used for signing a jar

2016-11-03 Thread Sean Mullan
You should only unset the jdk.jar.disabledAlgorithms property if a jarfile has been specified. Also, you are printing the warning message for all usages of the -printcert option, -ssl, etc, which is not correct. But I don't really think the warning message is necessary. The docs for the -pri

Re: RFR(s): 8169002: [TESTBUG] Several java/net/httpclient have undeclared dependency on java.logging module

2016-11-03 Thread Sergei Kovalev
Hi, Beside of listed in the review tests there are another tests in the folder. In case I'd update TEST.properties the not listed tests also will get unnecessary dependency from java.logging. -- With best regards, Sergei On 1 Nov 2016, at 18:40, Roger Riggs