Hello, just a Nit, but should this be clientNet/AppOutbound instead of Inbound
(or maybe use Response instead?) in ClientHelloInterOp#run
Is it Ok that there is no asserts? What cipher would be picked for example?
ClientHelloInterOp
In 271+304 I would use try-with-resource or not close the in mem
Thanks for review. I will go ahead and push the changeset. The latest
update is:
http://cr.openjdk.java.net/~xuelei/8169362/webrev.01/
Xuelei
On 11/10/2016 9:41 AM, Bradford Wetmore wrote:
Hi Xuelei,
Nothing major, mostly nits and some Netbeans suggestions.
On 11/9/2016 5:17 AM, Xuelei
Hi Xuelei,
Nothing major, mostly nits and some Netbeans suggestions.
On 11/9/2016 5:17 AM, Xuelei Fan wrote:
Hi,
Please review this test enhancement:
http://cr.openjdk.java.net/~xuelei/8169362/webrev.00/
This update adds a interop new test case with Chrome ClientHello message.
ClientHel
Upated webrev:
http://cr.openjdk.java.net/~xuelei/8169362/webrev.01/
Comparing the webrev.00, the logging class field is removed.
Xuelei
On 11/9/2016 9:17 PM, Xuelei Fan wrote:
Hi,
Please review this test enhancement:
http://cr.openjdk.java.net/~xuelei/8169362/webrev.00/
This update a
Looks fine to me.
Thanks.
> On 9 Nov 2016, at 11:26, Seán Coffey wrote:
>
> A bad test code merge occurred when 8u112 and CPU code was being merged a few
> weeks ago. Some extra functionality added to a helper test was lost. This fix
> restores it. 8u applicable only.
>
> diff --git a/test/s
Hi,
Please review this test enhancement:
http://cr.openjdk.java.net/~xuelei/8169362/webrev.00/
This update adds a interop new test case with Chrome ClientHello message.
Thanks,
Xuelei
A bad test code merge occurred when 8u112 and CPU code was being merged
a few weeks ago. Some extra functionality added to a helper test was
lost. This fix restores it. 8u applicable only.
diff --git a/test/sun/security/tools/jarsigner/warnings/Test.java
b/test/sun/security/tools/jarsigner/war
