Re: Code Review Request, JDK-8166103 Allow certs with unknown critical extension in SunX509 validator

2016-11-11 Thread Bradley Hess
The test case fails for me against JDK 1.7.0_05 and 1.8.0_20 -- the SunX509 validator complains about the presence of the critical extension. Contrary to what the OP suggested in the bug report, it doesn't seem like this behavior is new. Plenty of implementations in the wild (e.g. Tomcat) either

Re: RFR: 8168861 AnchorCertificates uses hardcoded password for cacerts keystore

2016-11-11 Thread Vincent Ryan
Your fix looks good to me Tony. Thanks. > On 10 Nov 2016, at 21:55, Anthony Scarpino > wrote: > > Hi, > > I need a one line review to null out the password field in the keystore load > op.. > > http://cr.openjdk.java.net/~ascarpino/8168861/webrev/ > > thanks > > Tony

Re: Code Review Request, JDK-8166103 Allow certs with unknown critical extension in SunX509 validator

2016-11-11 Thread Vincent Ryan
Your changes look fine to me. Just a minor language correction: ‘to use’ -> ‘using’ (2 instances) > On 11 Nov 2016, at 05:11, Xuelei Fan wrote: > > Hi, > > Please review this bug fix: > > http://cr.openjdk.java.net/~xuelei/8166103/webrev.00/ > > The current validator implementations only al