Re: RFR 8169911: Enhanced tests for jarsigner -verbose -verify after JDK-8163304

2016-11-18 Thread Wang Weijun
Hi Amanda - There are many duplicates in signWithAlias() and sign(). I think it's better to make one based on the other. Maybe signWithAliasAndTsa() and sign(). - checkWeak2() is about combinations of weak/strong algs in a single signer. I'd rather it be an individual test case, and not as a st

RFR 8169911: Enhanced tests for jarsigner -verbose -verify after JDK-8163304

2016-11-18 Thread Amanda Jiang
HI All, Please help to review following code change: webrev: http://cr.openjdk.java.net/~amjiang/8169911/webrev.01/ bug: https://bugs.openjdk.java.net/browse/JDK-8169911 This change enhances test case for JDK-8163304 by covering following cases: - Multiple signers (signed by jarsigner twi