Please review this patch. Thanks!
John Jiang
On 2016/11/19 19:38, John Jiang wrote:
After push for JDK-8168969, this fix has to use updated
SSLSocketTemplate.java.
Please review the updated webrev:
http://cr.openjdk.java.net/~jjiang/8164595/webrev.01
Best regards,
John Jiang
On 2016/10/27
Looks fine to me.
Thanks,
Xuelei
> On 23 Nov 2016, at 5:41 AM, Roger Riggs wrote:
>
> Adding security-dev...
>
> Please review this change to remove an ineffective finalizer for SSLSessions.
> The finalizer removes bindings from the SSLSession of a table that is also
> freed when the SSLSessio
Adding security-dev...
Please review this change to remove an ineffective finalizer for
SSLSessions.
The finalizer removes bindings from the SSLSession of a table that is also
freed when the SSLSession is being freed. There is no point in removing
them explicitly.
It only delays freeing memory
On 11/22/2016 11:48 AM, Jamil Nimeh wrote:
> A regression test for debug output? Is that something that we've done
> in the past with other debug fixes?
I thought we had some at one point, but can't find it now. Maybe not
worth worrying about.
IIRC, we had a shell script that ran with java
A regression test for debug output? Is that something that we've done
in the past with other debug fixes?
--Jamil
On 11/22/2016 11:36 AM, Bradford Wetmore wrote:
Ditto.
Does this need a regression test? Not really critical, but might be
worth thinking up one.
Brad
On 11/22/2016 10:50
Ditto.
Does this need a regression test? Not really critical, but might be
worth thinking up one.
Brad
On 11/22/2016 10:50 AM, Vincent Ryan wrote:
Looks fine to me.
Thanks.
On 22 Nov 2016, at 18:45, Jamil Nimeh wrote:
Hello all,
This is a short webrev that adds extra debug output th
Looks fine to me.
Thanks.
> On 22 Nov 2016, at 18:45, Jamil Nimeh wrote:
>
> Hello all,
>
> This is a short webrev that adds extra debug output that will show users
> which ciphers are not in the enabled list due to being disabled by things
> like jdk.tls.disabledAlgorithms, etc.
>
> Bug: h
Hello all,
This is a short webrev that adds extra debug output that will show users
which ciphers are not in the enabled list due to being disabled by
things like jdk.tls.disabledAlgorithms, etc.
Bug: https://bugs.openjdk.java.net/browse/JDK-8170035
Webrev: http://cr.openjdk.java.net/~jnimeh/
On 11/22/2016 05:19 AM, Sean Mullan wrote:
On 11/21/16 5:43 PM, Anthony Scarpino wrote:
On 11/21/2016 01:09 PM, Sean Mullan wrote:
Please review this fix for a bug where certificates were not being
blocked if the algorithm is only listed in the
jdk.tls.disabledAlgorithms property and not the
jd
On 11/21/16 5:43 PM, Anthony Scarpino wrote:
On 11/21/2016 01:09 PM, Sean Mullan wrote:
Please review this fix for a bug where certificates were not being
blocked if the algorithm is only listed in the
jdk.tls.disabledAlgorithms property and not the
jdk.certpath.disabledAlgorithms property.
I h
10 matches
Mail list logo