Re: RFR[9] JDK-8164595: javax/net/ssl/FixingJavadocs/SSLSessionNulls.java fails intermittently with javax.net.ssl.SSLHandshakeException: Remote host terminated the handshake

2016-11-22 Thread John Jiang
Please review this patch. Thanks! John Jiang On 2016/11/19 19:38, John Jiang wrote: After push for JDK-8168969, this fix has to use updated SSLSocketTemplate.java. Please review the updated webrev: http://cr.openjdk.java.net/~jjiang/8164595/webrev.01 Best regards, John Jiang On 2016/10/27

Re: RFR 9: 8169416: SSLSessionImpl finalize overhead

2016-11-22 Thread Xuelei Fan
Looks fine to me. Thanks, Xuelei > On 23 Nov 2016, at 5:41 AM, Roger Riggs wrote: > > Adding security-dev... > > Please review this change to remove an ineffective finalizer for SSLSessions. > The finalizer removes bindings from the SSLSession of a table that is also > freed when the SSLSessio

Re: RFR 9: 8169416: SSLSessionImpl finalize overhead

2016-11-22 Thread Roger Riggs
Adding security-dev... Please review this change to remove an ineffective finalizer for SSLSessions. The finalizer removes bindings from the SSLSession of a table that is also freed when the SSLSession is being freed. There is no point in removing them explicitly. It only delays freeing memory

Re: RFR 8170035: When determining the ciphersuite lists, there is no debug output for disabled suites

2016-11-22 Thread Bradford Wetmore
On 11/22/2016 11:48 AM, Jamil Nimeh wrote: > A regression test for debug output? Is that something that we've done > in the past with other debug fixes? I thought we had some at one point, but can't find it now. Maybe not worth worrying about. IIRC, we had a shell script that ran with java

Re: RFR 8170035: When determining the ciphersuite lists, there is no debug output for disabled suites

2016-11-22 Thread Jamil Nimeh
A regression test for debug output? Is that something that we've done in the past with other debug fixes? --Jamil On 11/22/2016 11:36 AM, Bradford Wetmore wrote: Ditto. Does this need a regression test? Not really critical, but might be worth thinking up one. Brad On 11/22/2016 10:50

Re: RFR 8170035: When determining the ciphersuite lists, there is no debug output for disabled suites

2016-11-22 Thread Bradford Wetmore
Ditto. Does this need a regression test? Not really critical, but might be worth thinking up one. Brad On 11/22/2016 10:50 AM, Vincent Ryan wrote: Looks fine to me. Thanks. On 22 Nov 2016, at 18:45, Jamil Nimeh wrote: Hello all, This is a short webrev that adds extra debug output th

Re: RFR 8170035: When determining the ciphersuite lists, there is no debug output for disabled suites

2016-11-22 Thread Vincent Ryan
Looks fine to me. Thanks. > On 22 Nov 2016, at 18:45, Jamil Nimeh wrote: > > Hello all, > > This is a short webrev that adds extra debug output that will show users > which ciphers are not in the enabled list due to being disabled by things > like jdk.tls.disabledAlgorithms, etc. > > Bug: h

RFR 8170035: When determining the ciphersuite lists, there is no debug output for disabled suites

2016-11-22 Thread Jamil Nimeh
Hello all, This is a short webrev that adds extra debug output that will show users which ciphers are not in the enabled list due to being disabled by things like jdk.tls.disabledAlgorithms, etc. Bug: https://bugs.openjdk.java.net/browse/JDK-8170035 Webrev: http://cr.openjdk.java.net/~jnimeh/

Re: RFR: 8170131: Certificates not being blocked by jdk.tls.disabledAlgorithms property

2016-11-22 Thread Anthony Scarpino
On 11/22/2016 05:19 AM, Sean Mullan wrote: On 11/21/16 5:43 PM, Anthony Scarpino wrote: On 11/21/2016 01:09 PM, Sean Mullan wrote: Please review this fix for a bug where certificates were not being blocked if the algorithm is only listed in the jdk.tls.disabledAlgorithms property and not the jd

Re: RFR: 8170131: Certificates not being blocked by jdk.tls.disabledAlgorithms property

2016-11-22 Thread Sean Mullan
On 11/21/16 5:43 PM, Anthony Scarpino wrote: On 11/21/2016 01:09 PM, Sean Mullan wrote: Please review this fix for a bug where certificates were not being blocked if the algorithm is only listed in the jdk.tls.disabledAlgorithms property and not the jdk.certpath.disabledAlgorithms property. I h