Re: RFR 8170364: FilePermission path modified during merge

On 28/11/2016 08:40, Wang Weijun wrote: Hi Alan Updated webrev at http://cr.openjdk.java.net/~weijun/8170364/webrev.01 Changes since webrev.00: - a private constructor that can clones 4 fields and modifies 5 others - using lambda - test enhancement This looks much better. A minor nit

Re: RFR(s): JDK-8169866: [TESTBUG] com/sun/security/ tests have undeclared modules dependencies

Hi Sergei Looks good to me. Thanks Max On 11/28/2016 9:17 PM, Sergei Kovalev wrote: R-sending request for review 17.11.16 15:43, Sergei Kovalev wrote: Hello team, Please review a small fix for security tests. BugID: https://bugs.openjdk.java.net/browse/JDK-8169866 Web review: http://cr.op

Re: RFR(s): JDK-8169866: [TESTBUG] com/sun/security/ tests have undeclared modules dependencies

R-sending request for review 17.11.16 15:43, Sergei Kovalev wrote: Hello team, Please review a small fix for security tests. BugID: https://bugs.openjdk.java.net/browse/JDK-8169866 Web review: http://cr.openjdk.java.net/~skovalev/8169866/webrev.00/ Issue: Tests from package com/sun/security

Re: RFR 8170364: FilePermission path modified during merge

Hi Alan Updated webrev at http://cr.openjdk.java.net/~weijun/8170364/webrev.01 Changes since webrev.00: - a private constructor that can clones 4 fields and modifies 5 others - using lambda - test enhancement Thanks Max