RE: RFR(M): 8170525: Fix minor issues in awt coding

Hi Vincent, I fixed the typo and added a remark to the first line of the bug text. Best regards, Goetz. > -Original Message- > From: Vincent Ryan [mailto:[email protected]] > Sent: Mittwoch, 30. November 2016 17:10 > To: Lindenmaier, Goetz > Cc: [email protected]; secu

[9] RFR JDK-8157529 : Remove intermittent key from javax/net/ssl/DTLS/CipherSuite.java

Hi , Would you help to review the path for "8157529:Remove intermittent key from javax/net/ssl/DTLS/CipherSuite.java" , the intermittently failed issue was fixed by JDK-8167680 , '@key intermittent ' can be removed.Thanks. JBS: https://bugs.openjdk.java.net/browse/JDK-8157529 webrev: http://c

Re: RFR: 8169335: Add a crypto.policy fallback in case Security Property 'crypto.policy' does not exist

I've updated to: * @run main/othervm CryptoPolicyFallback I'll have a new review out shortly. Brad On 11/23/2016 2:29 AM, Wang Weijun wrote: Hi Brad I think I found a problem with the test. Before you set your local java.security file, the system java.security file was already read (in jtr

Re: [OpenJDK 2D-Dev] RFR(M): 8170525: Fix minor issues in awt coding

Hi Goetz, DataBufferNative.c Using uninitialized value lockInfo.rasBase when calling DBN_GetPixelPointer. 75 lockInfo.resBase = NULL; Did you actually compile this ? The variable is called "rasBase", not "resBase". And strictly there is no problem since inside DBN_GetPixelPointer

RE: RFR(M): 8170525: Fix minor issues in awt coding

Hi Goetz, I have some small remarks. src/java.desktop/unix/native/common/awt/fontpath.c: 247 fontDirPath[sizeof(fontDirPath)-1] = '\0'; -> you should add spaces left and right of '-' 248 strncat(fontDirPath, "/fonts.dir", sizeof(fontDirPath) - strlen(fontDirPath)); -> I

Re: RFR(M): 8170525: Fix minor issues in awt coding

cc 2d-dev. On 30.11.16 18:41, Lindenmaier, Goetz wrote: Hi Vincent, thanks for the quit review! Good catch that I lost the change to p11_mutex.c ... I had to change it and it fell out of my patches. I edited the Last Modified Date, and also updated the copyright messages. New webrev: http://cr.

Re: RFR(M): 8170525: Fix minor issues in awt coding

Note that I have reviewed only the ECC/PKCS11 changes. You’ll need a JDK 9 reviewer from awt-dev for your remaining changes. There is a minor typo in the commit message: s/ece/ECC Also please change the Bug Summary in JBS to indicate that ECC and PKCS11 changes are also present. > On 30 Nov 20

RE: RFR(M): 8170525: Fix minor issues in awt coding

Hi Vincent, thanks for the quit review! Good catch that I lost the change to p11_mutex.c ... I had to change it and it fell out of my patches. I edited the Last Modified Date, and also updated the copyright messages. New webrev: http://cr.openjdk.java.net/~goetz/wr16/8170525-awt-dev/ Best rega

Re: RFR(M): 8170525: Fix minor issues in awt coding

Hello Goetz, Please modify the bug summary to reference ECC too. Your ECC changes look fine but the ‘Last Modified Date’ line in the 4 source code headers will need to be updated/added. BTW p11_mutex.c is listed below but appears to be missing from the webrev. Thanks. > On 30 Nov 2016, at 13

RFR(M): 8170525: Fix minor issues in awt coding

Hi, I'd like to propose a row of smaller fixes where code is noted down a bit questionable. SAP's quality process requires that we fix these in our internal delivery, and I Would like to share my fixes with openJdk. Some of these fixes are of more theoretical nature as how I understand the code

Re: [9] RFR 8170247: java/security/SecureRandom/ApiTest fails when run with unlimited policy.

Change looks fine. One nit: the extra space at the beginning of line 24 looks strange. Thanks Max On 11/30/2016 5:27 PM, Sibabrata Sahoo wrote: Hi, Please review the patch for, JBS: https://bugs.openjdk.java.net/browse/JDK-8170247 Webrev: http://cr.openjdk.java.net/~ssahoo/8170247/webre

[9] RFR 8170247: java/security/SecureRandom/ApiTest fails when run with unlimited policy.

Hi, Please review the patch for, JBS: https://bugs.openjdk.java.net/browse/JDK-8170247 Webrev: http://cr.openjdk.java.net/~ssahoo/8170247/webrev.00/ Description: The Test was failing to handle the expected failure for invalid parameters, when the SecureRandom parameter size is > algo