Re: RFR 8171423: Relocate /test/lib/security/SecurityTools.java

2017-01-11 Thread Weijun Wang
Sorry, I am replying too fast. If you can remove the existing file in the jdk repo, then everything is fine. Thanks Max On 01/12/2017 03:56 PM, Weijun Wang wrote: Looks fine to me. Thanks Max On 01/12/2017 03:05 AM, Amanda Jiang wrote: Hi All, Please help to review the webrev below, whic

Re: RFR 8171423: Relocate /test/lib/security/SecurityTools.java

2017-01-11 Thread Weijun Wang
Looks fine to me. Thanks Max On 01/12/2017 03:05 AM, Amanda Jiang wrote: Hi All, Please help to review the webrev below, which moves the utility class SecurityTools to root repo. Bug: https://bugs.openjdk.java.net/browse/JDK-8171423 Webrev: http://cr.openjdk.java.net/~amjiang/8171423/webrev.0

Re: RFR 8168075: Custom system class loader + security manager + malformed policy file = recursive initialization

2017-01-11 Thread Wang Weijun
Is there a valid case where a security manager is created but not set? --Max > On Jan 12, 2560 BE, at 7:18 AM, Claes Redestad > wrote: > > Hi again, > > On 2017-01-11 15:27, Claes Redestad wrote: >> Hi Adam, >> >> On 01/11/2017 02:34 PM, Adam Petcher wrote: >>> Please review the following bu

Re: RFR 8168075: Custom system class loader + security manager + malformed policy file = recursive initialization

2017-01-11 Thread Claes Redestad
Hi again, On 2017-01-11 15:27, Claes Redestad wrote: Hi Adam, On 01/11/2017 02:34 PM, Adam Petcher wrote: Please review the following bug fix: http://cr.openjdk.java.net/~apetcher/8168075/webrev.00/ This fixes a bug in which a permission check would try to load resources while the system cla

RFR 8171423: Relocate /test/lib/security/SecurityTools.java

2017-01-11 Thread Amanda Jiang
Hi All, Please help to review the webrev below, which moves the utility class SecurityTools to root repo. Bug: https://bugs.openjdk.java.net/browse/JDK-8171423 Webrev: http://cr.openjdk.java.net/~amjiang/8171423/webrev.00/ Thanks, Amanda

Feedback on SSLEngine.setHandshakeApplicationProtocolSelector()

2017-01-11 Thread Simone Bordet
Hi, I just wanted to report that I have implemented the new mechanism provided by SSLEngine.setHandshakeApplicationProtocolSelector() in Jetty, and it works well in a much much simpler way. The amount of code required now is trivial (a couple of lines), there is no need to parse the ClientHello,

Re: RFR 8168075: Custom system class loader + security manager + malformed policy file = recursive initialization

2017-01-11 Thread Claes Redestad
Hi, On 01/11/2017 03:56 PM, Adam Petcher wrote: On 1/11/2017 9:27 AM, Claes Redestad wrote: Hi Adam, On 01/11/2017 02:34 PM, Adam Petcher wrote: Please review the following bug fix: http://cr.openjdk.java.net/~apetcher/8168075/webrev.00/ This fixes a bug in which a permission check would t

RE: [9] RFR: 8168423: Test Task: Custom system class loader + security manager + malformed policy file = recursive initialization

2017-01-11 Thread Sibabrata Sahoo
Hi Adam/Sean, This patch is waiting for your review. Thanks, Siba From: Sibabrata Sahoo Sent: Friday, December 02, 2016 6:56 PM To: Sean Mullan; [email protected] Subject: [9] RFR: 8168423: Test Task: Custom system class loader + security manager + malformed policy file =

Re: RFR 8168075: Custom system class loader + security manager + malformed policy file = recursive initialization

2017-01-11 Thread Adam Petcher
On 1/11/2017 9:27 AM, Claes Redestad wrote: Hi Adam, On 01/11/2017 02:34 PM, Adam Petcher wrote: Please review the following bug fix: http://cr.openjdk.java.net/~apetcher/8168075/webrev.00/ This fixes a bug in which a permission check would try to load resources while the system class loade

Re: RFR 8168075: Custom system class loader + security manager + malformed policy file = recursive initialization

2017-01-11 Thread Claes Redestad
Hi Adam, On 01/11/2017 02:34 PM, Adam Petcher wrote: Please review the following bug fix: http://cr.openjdk.java.net/~apetcher/8168075/webrev.00/ This fixes a bug in which a permission check would try to load resources while the system class loader is being initialized. Resources cannot be l

RFR 8168075: Custom system class loader + security manager + malformed policy file = recursive initialization

2017-01-11 Thread Adam Petcher
Please review the following bug fix: http://cr.openjdk.java.net/~apetcher/8168075/webrev.00/ This fixes a bug in which a permission check would try to load resources while the system class loader is being initialized. Resources cannot be loaded at this time, so this change ensures that the res