Re: RFR 8168075: Custom system class loader + security manager + malformed policy file = recursive initialization

2017-01-13 Thread Mandy Chung
> On Jan 13, 2017, at 7:30 AM, Sean Mullan wrote: > > On 1/12/17 3:53 PM, Mandy Chung wrote: >> >>> On Jan 11, 2017, at 5:34 AM, Adam Petcher >>> wrote: >>> >>> Please review the following bug fix: >>> >>> http://cr.openjdk.java.net/~apetcher/8168075/webrev.00/ >>> >>> This fixes a bug in w

Re: RFR 8168075: Custom system class loader + security manager + malformed policy file = recursive initialization

2017-01-13 Thread Adam Petcher
On 1/13/2017 10:30 AM, Sean Mullan wrote: On 1/12/17 3:53 PM, Mandy Chung wrote: On Jan 11, 2017, at 5:34 AM, Adam Petcher wrote: Please review the following bug fix: http://cr.openjdk.java.net/~apetcher/8168075/webrev.00/ This fixes a bug in which a permission check would try to load res

Re: RFR 8168075: Custom system class loader + security manager + malformed policy file = recursive initialization

2017-01-13 Thread Sean Mullan
On 1/12/17 3:53 PM, Mandy Chung wrote: On Jan 11, 2017, at 5:34 AM, Adam Petcher wrote: Please review the following bug fix: http://cr.openjdk.java.net/~apetcher/8168075/webrev.00/ This fixes a bug in which a permission check would try to load resources while the system class loader is bein

Re: Asking for a name change in sun.security.provider.certpath.BasicChecker

2017-01-13 Thread Sean Mullan
On 1/13/17 4:09 AM, Weijun Wang wrote: This class has a method called verifyTimestamp() but it's actually about the validity period fields in a certificate. I found it quite misleading because whenever I see timestamp I think of TSA and RFC 3161. Are you OK with changing all occurrences of "time

Re: RFR: 8037325: Class.getConstructor() performance regression

2017-01-13 Thread Claes Redestad
Hi Christoph, thanks for looking at this! Extracting methodName was part cleanup, part meant to outline some rarely executed error handling code, which can help a JIT focus on the critical path. I'd prefer not to micro-optimize argumentTypesToString (and would likely look at other things than S

Re: RFR 8172422: jarsigner needs to understand -?

2017-01-13 Thread Sean Mullan
Looks ok, but is this for JDK 9? If so, we shouldn't be fixing P4 bugs now since we are in Rampdown Phase 1. --Sean On 1/13/17 6:51 AM, Weijun Wang wrote: Please review this code change: diff --git a/src/java.base/share/classes/sun/security/tools/keytool/Main.java b/src/java.base/share/classe

RFR 8172422: jarsigner needs to understand -?

2017-01-13 Thread Weijun Wang
Please review this code change: diff --git a/src/java.base/share/classes/sun/security/tools/keytool/Main.java b/src/java.base/share/classes/sun/security/tools/keytool/Main.java --- a/src/java.base/share/classes/sun/security/tools/keytool/Main.java +++ b/src/java.base/share/classes/sun/security

Asking for a name change in sun.security.provider.certpath.BasicChecker

2017-01-13 Thread Weijun Wang
This class has a method called verifyTimestamp() but it's actually about the validity period fields in a certificate. I found it quite misleading because whenever I see timestamp I think of TSA and RFC 3161. Are you OK with changing all occurrences of "timestamp" to "validity"? This includes t