Re: 9 RFR of JDK-8176337: Mark several tests as intermittently failing

2017-03-07 Thread joe darcy
Looks fine Hamlin; thanks, -Joe On 3/7/2017 7:36 PM, Hamlin Li wrote: Would you please review below patch? bug: https://bugs.openjdk.java.net/browse/JDK-8176337 webrev: http://cr.openjdk.java.net/~mli/8176337/webrev.00/ These tests are failing intermittently, they should be marked accordi

Re: RFR 8176320: security/tools/jarsigner/TsacertOptionTest.java compilation error, all mach 5 tier 2 platforms broken.

2017-03-07 Thread Xuelei Fan
Looks fine to me. Xuelei On 3/7/2017 7:19 PM, Weijun Wang wrote: Please review this fix: diff --git a/test/sun/security/tools/jarsigner/TsacertOptionTest.java b/test/sun/security/tools/jarsigner/TsacertOptionTest.java --- a/test/sun/security/tools/jarsigner/TsacertOptionTest.java +++ b/test/su

RFR 8176320: security/tools/jarsigner/TsacertOptionTest.java compilation error, all mach 5 tier 2 platforms broken.

2017-03-07 Thread Weijun Wang
Please review this fix: diff --git a/test/sun/security/tools/jarsigner/TsacertOptionTest.java b/test/sun/security/tools/jarsigner/TsacertOptionTest.java --- a/test/sun/security/tools/jarsigner/TsacertOptionTest.java +++ b/test/sun/security/tools/jarsigner/TsacertOptionTest.java @@ -29,6 +29,7 @

Re: RFR 8175846: Provide javadoc descriptions for jdk.policytool and jdk.crypto.* modules

2017-03-07 Thread Weijun Wang
There was no "forRemoval=true" for the sun.security.tools.policytool.Main class itself either. I'll file a bug and add it to both. Thanks Max On 03/08/2017 12:07 AM, Sean Mullan wrote: On 3/7/17 9:44 AM, Weijun Wang wrote: Ping again. Sorry I missed this before you pushed the changeset, bu

Re: RFR 8175846: Provide javadoc descriptions for jdk.policytool and jdk.crypto.* modules

2017-03-07 Thread Sean Mullan
On 3/7/17 9:44 AM, Weijun Wang wrote: Ping again. Sorry I missed this before you pushed the changeset, but the @Deprecated annotation for the jdk.policytool module should have "forRemoval=true" on it, since it scheduled for removal in JDK 10: https://bugs.openjdk.java.net/browse/JDK-8147400

Re: RFR 8176296: Test sun/security/krb5/auto/Basic.java faling after adding module declaration into TEST.properties.

2017-03-07 Thread Sergei Kovalev
Thanks that let me see. Good to know. 07.03.17 17:10, Weijun Wang wrote: Please review this changeset at http://cr.openjdk.java.net/~weijun/8176296/webrev.00/ It looks with jdk.security.jgss added into @modules in TEST.properties (JDK-8176213), it cannot be exclude using --limit-modules.

Re: RFR 8175846: Provide javadoc descriptions for jdk.policytool and jdk.crypto.* modules

2017-03-07 Thread Vincent Ryan
Your comments look fine to me. > On 7 Mar 2017, at 14:44, Weijun Wang wrote: > > Ping again. > > On 03/01/2017 09:02 AM, Weijun Wang wrote: >> Please review the patch below. I don't know if all those jdk.crypto.* >> modules will be listed in the doc, but it's nice to include a comment. >> >>

Re: RFR 8175846: Provide javadoc descriptions for jdk.policytool and jdk.crypto.* modules

2017-03-07 Thread Weijun Wang
Ping again. On 03/01/2017 09:02 AM, Weijun Wang wrote: Please review the patch below. I don't know if all those jdk.crypto.* modules will be listed in the doc, but it's nice to include a comment. Thanks Max diff --git a/src/jdk.policytool/share/classes/module-info.java b/src/jdk.policytool/sha

Re: RFR 8171319: keytool should print out warnings when reading or generating cert/cert req using weak algorithms

2017-03-07 Thread Seán Coffey
Looks good to me. regards, Sean. On 03/03/2017 01:17, Weijun Wang wrote: Updated again at http://cr.openjdk.java.net/~weijun/8171319/webrev.03/ Changes: 1. No more prompt when algorithm/key is weak in keytool -importcert. This newly introduced prompt might hang a user script. Since we a

RFR 8176296: Test sun/security/krb5/auto/Basic.java faling after adding module declaration into TEST.properties.

2017-03-07 Thread Weijun Wang
Please review this changeset at http://cr.openjdk.java.net/~weijun/8176296/webrev.00/ It looks with jdk.security.jgss added into @modules in TEST.properties (JDK-8176213), it cannot be exclude using --limit-modules. Therefore I split Basic.java into 2 and the new test has its own @modules

Re: RFR(s): 8176213: 78 sun/security/krb5/auto tests failing due to undeclared dependecies

2017-03-07 Thread Weijun Wang
Change looks fine. Do you need me pushing it for you? Thanks Max On 03/07/2017 06:40 PM, Sergei Kovalev wrote: Good point. For same reason I've removed module declaration from PrincipalSystemPropTest.java. Now it uses TETS.properties config. Please take a look. http://cr.openjdk.java.net/~sko

Re: RFR(s): 8176213: 78 sun/security/krb5/auto tests failing due to undeclared dependecies

2017-03-07 Thread Sergei Kovalev
Good point. For same reason I've removed module declaration from PrincipalSystemPropTest.java. Now it uses TETS.properties config. Please take a look. http://cr.openjdk.java.net/~skovalev/8176213/webrev.01/ 07.03.17 13:30, Weijun Wang wrote: On 03/07/2017 05:50 PM, Sergei Kovalev wrote: H

Re: RFR(s): 8176213: 78 sun/security/krb5/auto tests failing due to undeclared dependecies

2017-03-07 Thread Weijun Wang
On 03/07/2017 05:50 PM, Sergei Kovalev wrote: Hi Max, Thank you for review. 07.03.17 02:15, Weijun Wang wrote: Hi Sergei Two questions: 1. Can we remove the @modules section in Renew.java so that it uses the one in TEST.properties? We can however TEST.properties contains jdk.security.jgs

Re: RFR(s): 8176213: 78 sun/security/krb5/auto tests failing due to undeclared dependecies

2017-03-07 Thread Sergei Kovalev
Hi Max, Thank you for review. 07.03.17 02:15, Weijun Wang wrote: Hi Sergei Two questions: 1. Can we remove the @modules section in Renew.java so that it uses the one in TEST.properties? We can however TEST.properties contains jdk.security.jgss module dependency but Renew.java doesn't. If w