Re: [10] RFR 8177085: Accept including .conf files in krb5.conf's includedir

2017-03-21 Thread Weijun Wang
Good, and I can push my current changeset now. Thanks Max On 03/22/2017 11:48 AM, Jamil Nimeh wrote: On 3/21/2017 5:53 PM, Weijun Wang wrote: On 03/21/2017 11:13 PM, Weijun Wang wrote: Maybe I can report this to MIT krb5 and ask if they are afraid of it. See http://mailman.mit.edu/piperm

Re: [10] RFR 8177085: Accept including .conf files in krb5.conf's includedir

2017-03-21 Thread Jamil Nimeh
On 3/21/2017 5:53 PM, Weijun Wang wrote: On 03/21/2017 11:13 PM, Weijun Wang wrote: Maybe I can report this to MIT krb5 and ask if they are afraid of it. See http://mailman.mit.edu/pipermail/krbdev/2017-March/012744.html. Do you suggest we exclude files starting with a dot now? Or we wait

Re: [10] RFR 8177085: Accept including .conf files in krb5.conf's includedir

2017-03-21 Thread Weijun Wang
On 03/21/2017 11:13 PM, Weijun Wang wrote: Maybe I can report this to MIT krb5 and ask if they are afraid of it. See http://mailman.mit.edu/pipermail/krbdev/2017-March/012744.html. Do you suggest we exclude files starting with a dot now? Or we wait until MIT krb5 implements it first? Than

Re: RFR 8176536: Backport weak algorithms checking

2017-03-21 Thread Sean Mullan
Looks good. Thanks, Sean On 3/20/17 5:02 PM, Anthony Scarpino wrote: Hi Sean, I updated the webrev with your recent change. One you ok this, I'll request approval for backport. http://cr.openjdk.java.net/~ascarpino/8176536/webrev.01/ thanks Tony On 03/17/2017 01:25 PM, Anthony Scarpino w

Re: [10] RFR 8177085: Accept including .conf files in krb5.conf's includedir

2017-03-21 Thread Weijun Wang
On 03/21/2017 11:03 PM, Jamil Nimeh wrote: Honestly, I can't. I could see a sysadmin maybe moving a file like foo.conf maybe to .foo.conf in order to "hide" it, but that wouldn't do much now (it will still be processed) and now you have a situation where the admin has a file being processed th

Re: [10] RFR 8177085: Accept including .conf files in krb5.conf's includedir

2017-03-21 Thread Jamil Nimeh
Hi Max, On 3/20/2017 7:18 PM, Weijun Wang wrote: On 03/19/2017 11:41 PM, Jamil Nimeh wrote: Hi Max, Do you know if the MIT krb5 code accepts any filename with the .conf extension? So filenames with spaces and periods with a .conf suffix are fine? I just wanted to make sure because your tes

Re: RFR(s): 8177324: Some javax/security/ tests don't have correct module dependencies

2017-03-21 Thread Weijun Wang
The change looks good. Thanks Max On 03/21/2017 06:44 PM, Sergei Kovalev wrote: Hi team, Please review below small fix for security tests. BugID: https://bugs.openjdk.java.net/browse/JDK-8177324 Review: http://cr.openjdk.java.net/~skovalev/8177324/webrev.00 Issue: missed dependency declarati

RFR(s): 8177324: Some javax/security/ tests don't have correct module dependencies

2017-03-21 Thread Sergei Kovalev
Hi team, Please review below small fix for security tests. BugID: https://bugs.openjdk.java.net/browse/JDK-8177324 Review: http://cr.openjdk.java.net/~skovalev/8177324/webrev.00 Issue: missed dependency declaration in some security tests. -- With best regards, Sergei