I understand the interest in having test pass reliably, but I don't
think giving the test very large timeouts is the preferred way of
accomplishing that.
For all configurations, the test can now run for up to 20 minutes, up
from 4 minutes. We want to run the entire test suite, thousands of
te
+1
Joe
On 4/27/2017 12:08 PM, Brent Christian wrote:
Hi,
This test times out under our automated testing configurations that
include -Xcomp.
Please review my change to increase the timeout for this test. It is
sufficient for the test configurations in question to pass on two
different lo
Update the copyright date. Otherwise looks fine.
--Sean
On 4/27/17 10:37 AM, Weijun Wang wrote:
Please review this small doc change:
diff --git
a/src/java.security.jgss/share/classes/org/ietf/jgss/package.html
b/src/java.security.jgss/share/classes/org/ietf/jgss/package.html
--- a/src/java.sec
Only comment is updating the copyright dates to 2017.
Brad
On 4/26/2017 6:23 PM, Mandy Chung wrote:
Looks okay.
Mandy
On Apr 26, 2017, at 5:50 PM, Jonathan Gibbons
wrote:
Please review these mostly simple changes to replace HTML tags which are not
valid in HTML 5 in public doc comments
> On Apr 26, 2017, at 6:49 PM, Jonathan Gibbons
> wrote:
>
> Updated webrev to address Joe's suggestion to try harder to use {@code} as a
> substitute for .
>
> http://cr.openjdk.java.net/~jjg/8179370/webrev.01
Looks good.
Mandy
Please review this small doc change:
diff --git
a/src/java.security.jgss/share/classes/org/ietf/jgss/package.html
b/src/java.security.jgss/share/classes/org/ietf/jgss/package.html
--- a/src/java.security.jgss/share/classes/org/ietf/jgss/package.html
+++ b/src/java.security.jgss/share/classes/o
On 27/04/2017 02:49, Jonathan Gibbons wrote:
Updated webrev to address Joe's suggestion to try harder to use
{@code} as a substitute for .
http://cr.openjdk.java.net/~jjg/8179370/webrev.01
The updated version using {@code ... } looks better and also keeps the
lines from growing too long.