Re: RFR 9 test-only RFR 8177328 : java/lang/ClassLoader/securityManager/ClassLoaderTest.java times out with -Xcomp

2017-04-27 Thread joe darcy
I understand the interest in having test pass reliably, but I don't think giving the test very large timeouts is the preferred way of accomplishing that. For all configurations, the test can now run for up to 20 minutes, up from 4 minutes. We want to run the entire test suite, thousands of te

Re: RFR 9 test-only RFR 8177328 : java/lang/ClassLoader/securityManager/ClassLoaderTest.java times out with -Xcomp

2017-04-27 Thread huizhe wang
+1 Joe On 4/27/2017 12:08 PM, Brent Christian wrote: Hi, This test times out under our automated testing configurations that include -Xcomp. Please review my change to increase the timeout for this test. It is sufficient for the test configurations in question to pass on two different lo

Re: RFR 8179369: src/java.security.jgss/share/classes/org/ietf/jgss/package.html should be HTML5-friendly

2017-04-27 Thread Sean Mullan
Update the copyright date. Otherwise looks fine. --Sean On 4/27/17 10:37 AM, Weijun Wang wrote: Please review this small doc change: diff --git a/src/java.security.jgss/share/classes/org/ietf/jgss/package.html b/src/java.security.jgss/share/classes/org/ietf/jgss/package.html --- a/src/java.sec

Re: RFR: 8179370: Replace use of , and tags in java.base

2017-04-27 Thread Brad R. Wetmore
Only comment is updating the copyright dates to 2017. Brad On 4/26/2017 6:23 PM, Mandy Chung wrote: Looks okay. Mandy On Apr 26, 2017, at 5:50 PM, Jonathan Gibbons wrote: Please review these mostly simple changes to replace HTML tags which are not valid in HTML 5 in public doc comments

Re: RFR: 8179370: Replace use of , and tags in java.base

2017-04-27 Thread Mandy Chung
> On Apr 26, 2017, at 6:49 PM, Jonathan Gibbons > wrote: > > Updated webrev to address Joe's suggestion to try harder to use {@code} as a > substitute for . > > http://cr.openjdk.java.net/~jjg/8179370/webrev.01 Looks good. Mandy

RFR 8179369: src/java.security.jgss/share/classes/org/ietf/jgss/package.html should be HTML5-friendly

2017-04-27 Thread Weijun Wang
Please review this small doc change: diff --git a/src/java.security.jgss/share/classes/org/ietf/jgss/package.html b/src/java.security.jgss/share/classes/org/ietf/jgss/package.html --- a/src/java.security.jgss/share/classes/org/ietf/jgss/package.html +++ b/src/java.security.jgss/share/classes/o

Re: RFR: 8179370: Replace use of , and tags in java.base

2017-04-27 Thread Alan Bateman
On 27/04/2017 02:49, Jonathan Gibbons wrote: Updated webrev to address Joe's suggestion to try harder to use {@code} as a substitute for . http://cr.openjdk.java.net/~jjg/8179370/webrev.01 The updated version using {@code ... } looks better and also keeps the lines from growing too long.