Re: RFR: 8178014: CryptoPolicyParser's API comment contains < and > characters

2017-05-01 Thread Kumar Srinivasan
+1 Kumar On 5/1/2017 1:55 PM, Sean Mullan wrote: Looks good to me. --Sean On 5/1/17 4:19 PM, Brad R. Wetmore wrote: Kumar (+ anyone else), Simple review for fixing two errors when building javadocs with -private (non-default option). Also, the 'name' attribute is no longer supported in HT

Re: RFR: 8178014: CryptoPolicyParser's API comment contains < and > characters

2017-05-01 Thread Sean Mullan
Looks good to me. --Sean On 5/1/17 4:19 PM, Brad R. Wetmore wrote: Kumar (+ anyone else), Simple review for fixing two errors when building javadocs with -private (non-default option). Also, the 'name' attribute is no longer supported in HTML5. So doing a trivial name->id rename to HTML5 cl

RFR: 8178014: CryptoPolicyParser's API comment contains < and > characters

2017-05-01 Thread Brad R. Wetmore
Kumar (+ anyone else), Simple review for fixing two errors when building javadocs with -private (non-default option). Also, the 'name' attribute is no longer supported in HTML5. So doing a trivial name->id rename to HTML5 cleanup the XML DSig docs. https://bugs.openjdk.java.net/browse

Re: RFR 9 test-only RFR 8177328 : java/lang/ClassLoader/securityManager/ClassLoaderTest.java times out with -Xcomp

2017-05-01 Thread Mandy Chung
> On May 1, 2017, at 12:47 PM, Brent Christian > wrote: > > >> One refactor you can consider by separating >> them in several @run actions. The timeout will apply to each action >> but that does not help shorten the test execution time. > > I had the same thought, and concluded that without

Re: RFR 9 test-only RFR 8177328 : java/lang/ClassLoader/securityManager/ClassLoaderTest.java times out with -Xcomp

2017-05-01 Thread Mandy Chung
Looks like this test execs a new VM for 66 times to exhaust the combination of with and without security manager, with a valid or malformed policy, client & custom loader in unnamed, named, automatic module. I think we could take out the automatic module case as named module would verify it. O