Re: RFR: [Updated] Update tables in java.base to be HTML5-friendly.

2017-05-10 Thread Martin Buchholz
Looks good. --- I suspect there's some way to specify the styles more compactly, but I don't know enough css to say. --- +table.borderless thead tr th, table.borderless tbody tr th, table.borderless tr th, +table.plain > thead > tr > th, table.plain > tbody > tr > th, table.plain > tr > th, I

Re: [10] RFR 8166222: Don't treat signed jars with invalid timestamps as unsigned

2017-05-10 Thread Weijun Wang
Ping again. On 04/12/2017 11:52 PM, Weijun Wang wrote: Please take a review at http://cr.openjdk.java.net/~weijun/8166222/webrev.00/ The major code change is inside SignatureFileVerifier.java. Now if the timestamp on a signed jar is invalid (For example, using a weak algorithm now disabled)

Re: RFR 8178794: krb5 client should ignore sname in incoming tickets

2017-05-10 Thread Weijun Wang
Ping again. On 04/14/2017 03:18 PM, Weijun Wang wrote: Hi Valerie Please take a review of http://cr.openjdk.java.net/~weijun/8178794/webrev.00/ The sname field in the ticket is meant to be read by a server and the client should use the one inside KDC-REP's enc-part. Thanks Max

Re: RFR: [Updated] Update tables in java.base to be HTML5-friendly.

2017-05-10 Thread Mandy Chung
> On May 5, 2017, at 3:52 PM, Jonathan Gibbons > wrote: > > This is an updated review for the changes to improve tables in java.base. > : > Webrevs: > > langtools (the stylesheet): > http://cr.openjdk.java.net/~jjg/8179479-8179592/8179479/webrev.01/ > > jdk (changes to java.base): > http://cr

Re: [10] RFR 8179389: X509Certificate generateCRLs is extremely slow using a PEM crl list

2017-05-10 Thread Sean Mullan
On 4/28/17 8:44 PM, Weijun Wang wrote: Please take a review at http://cr.openjdk.java.net/~weijun/8179389/webrev.00/ The bug report [1] is correct that the frequent reallocation of data is the problem. This fix above delegate this task to ByteArrayOutputStream. There is no significant pe