This looks fine.
Thanks
Max
> On Jul 7, 2017, at 1:30 PM, Hamlin Li wrote:
>
> Hi Max,
>
> As you suggested, remove comments and wrap long lines, updated webrev in
> place: http://cr.openjdk.java.net/~mli/8183990/webrev.00/
>
> Thank you
>
> -Hamlin
>
>
> On 2017/7/7 13:15, Weijun Wang wr
Hi Max,
As you suggested, remove comments and wrap long lines, updated webrev in
place: http://cr.openjdk.java.net/~mli/8183990/webrev.00/
Thank you
-Hamlin
On 2017/7/7 13:15, Weijun Wang wrote:
If the compiler is just complaining about characters in a comment, why not
simply remove the c
If the compiler is just complaining about characters in a comment, why not
simply remove the comment? Do you think the current test is wrong and the 2nd
half of the string must be added back?
Also, the string is still too long. I’d rather break it into multiple lines to
fit a normal screen widt
Would you please review the below patch?
bug: https://bugs.openjdk.java.net/browse/JDK-8183990
webrev: http://cr.openjdk.java.net/~mli/8183990/webrev.00/
Thank you
-Hamlin
On 7/5/17 4:01 PM, Adam Petcher wrote:
Very interesting. The exception originates in the VM, so I added the
hotspot-dev list to the discussion. It looks like the VM either can't
find the method, or it decides that it's not the right kind of method.
Right. The check that is causing this error
