Re: [10] RFR 8183509: keytool should not allow multiple commands

Looks good. --Sean On 7/7/17 10:55 AM, Weijun Wang wrote: Updated at http://cr.openjdk.java.net/~weijun/8183509/webrev.01/ Changes: http://cr.openjdk.java.net/~weijun/8183509/webrev.01/interdiff.patch.html Thanks Max On Jul 7, 2017, at 8:00 PM, Sean Mullan wrote: I would use "sp

Re: AccessController.doPrivileged and default methods

On 7/6/17 10:33 AM, Sean Mullan wrote: On 7/5/17 4:01 PM, Adam Petcher wrote: Very interesting. The exception originates in the VM, so I added the hotspot-dev list to the discussion. It looks like the VM either can't find the method, or it decides that it's not the right kind of method. Rig

Re: RFR 8182999: SunEC throws ProviderException on invalid curves

Adam, would it be useful to get the curve name in the new exception ? I think it would help with future debugging. Line 96 already gets the curve name if we're dealing with ECGenParameterSpec instance. I think the same approach could be applied to your new code. Regards, Sean. On 07/07/201

RFR 8182999: SunEC throws ProviderException on invalid curves

This is a bug fix related to invalid curves in the SunEC provider. During ECKeyPairGenerator.initialize(), the provider only checks whether the curve is known, but it doesn't check whether the curve is actually supported by the native code. So the call to generateKeyPair() can fail in the nativ

Re: [10] RFR 8183509: keytool should not allow multiple commands

Looks fine to me. > On 7 Jul 2017, at 15:55, Weijun Wang wrote: > > Updated at > > http://cr.openjdk.java.net/~weijun/8183509/webrev.01/ > > Changes: > > http://cr.openjdk.java.net/~weijun/8183509/webrev.01/interdiff.patch.html > > Thanks > Max > >> On Jul 7, 2017, at 8:00 PM, Sean Mull

Re: [10] RFR 8183509: keytool should not allow multiple commands

Updated at http://cr.openjdk.java.net/~weijun/8183509/webrev.01/ Changes: http://cr.openjdk.java.net/~weijun/8183509/webrev.01/interdiff.patch.html Thanks Max > On Jul 7, 2017, at 8:00 PM, Sean Mullan wrote: > > I would use "specified" instead of "provided" since that word is used more

Re: [10] RFR 8183509: keytool should not allow multiple commands

I would use "specified" instead of "provided" since that word is used more commonly in the keytool warnings. Thanks, Sean On 7/7/17 3:58 AM, Weijun Wang wrote: Please take a look at http://cr.openjdk.java.net/~weijun/8183509/webrev.00/ Multiple commands on the same keytool command line is no

[10] RFR 8183509: keytool should not allow multiple commands

Please take a look at http://cr.openjdk.java.net/~weijun/8183509/webrev.00/ Multiple commands on the same keytool command line is now an error. Specifying a single-valued option multiple times will trigger a warning. Thanks Max