Webrev updated:
- http://cr.openjdk.java.net/~weijun/8166222/root/webrev.01
Move the change for JarUtils.java here.
- http://cr.openjdk.java.net/~weijun/8166222/webrev.02/
Update multiple "is not validated" strings to "is invalid" in Resources.java.
Several tests that grep these words are also
> On Aug 2, 2017, at 4:21 PM, Jonathan Gibbons
> wrote:
>
> (I'm not sure if there is a better list for this request, but the request is
> so simple, I'm hoping it will be sufficient.
>
> Please review this very simple fix to replace two uses of ...
> with {@code...}.
>
> The underlying pro
On 8/2/2017 3:29 PM, Weijun Wang wrote:
Looks fine.
Maybe you can add a comment near the definition of these constants that when a
new one is added it should be listed in the isUnsupported() method.
Good suggestion! It's a concern of mine, too.
Thanks,
Xuelei
Thanks
Max
On Aug 3, 2017
Looks fine.
Maybe you can add a comment near the definition of these constants that when a
new one is added it should be listed in the isUnsupported() method.
Thanks
Max
> On Aug 3, 2017, at 6:18 AM, Xuelei Fan wrote:
>
> Hi,
>
> Please review the update:
> http://cr.openjdk.java.net/~xuel
Hi,
Please review the update:
http://cr.openjdk.java.net/~xuelei/8180643/webrev.00/
This update is trying to detect unknown or unsupported handshake
messages sooner rather later.
Thanks,
Xuelei
I am reading JaasModularClientTest.java now. It’s much simpler than the
original one. Some comments:
38: This ProcessTools is deprecated. Is it possible to use the one in root repo?
53: Why make it public?
98-99: What localized strings are you trying to avoid?
103-104: Why do these 2 variables
