[10] RFR 8186654 : Poor quality of sun.security.util.Cache.EqualByteArray.hashCode()

2017-08-23 Thread Ivan Gerasimov
Hello! An auxiliary class EqualByteArray implements hashCode() in a way that small changes to the content do not change the hash value. It is proposed to reuse Arrays.hashCode(byte[]) for the hash code calculations. Also, the private int hash is made non-volatile, as it removes accessing t

Re: [10] RFR: JDK-8183310: java/security/modules/ModularTest.java should clean up better

2017-08-23 Thread Weijun Wang
Hi Siba Change looks fine. I have no other comments. Thanks Max > On Aug 23, 2017, at 8:30 PM, Sibabrata Sahoo > wrote: > > Hi Max, > > Please find the updated webrev: > http://cr.openjdk.java.net/~ssahoo/8183310/webrev.02/ > > The setup will be called only once irrespective number of @run

RE: [10] RFR: JDK-8183310: java/security/modules/ModularTest.java should clean up better

2017-08-23 Thread Sibabrata Sahoo
Hi Max, Please find the updated webrev: http://cr.openjdk.java.net/~ssahoo/8183310/webrev.02/ The setup will be called only once irrespective number of @run available inside the Test file. Thanks, Siba -Original Message- From: Weijun Wang Sent: Wednesday, August 23, 2017 3:04 PM To:

Re: [10] RFR: JDK-8183310: java/security/modules/ModularTest.java should clean up better

2017-08-23 Thread Weijun Wang
Then maybe you can also make setup() a separate @run. --Max > On Aug 23, 2017, at 4:17 PM, Sibabrata Sahoo > wrote: > > Hi Max, > > I have splitted the @run to convert each run to consume minimum time to avoid > any timeout for rare cases. > > Thanks, > Siba > > -Original Message-

RE: [10] RFR: JDK-8183310: java/security/modules/ModularTest.java should clean up better

2017-08-23 Thread Sibabrata Sahoo
Hi Max, I have splitted the @run to convert each run to consume minimum time to avoid any timeout for rare cases. Thanks, Siba -Original Message- From: Weijun Wang Sent: Wednesday, August 23, 2017 1:43 PM To: Sibabrata Sahoo Cc: Valerie Peng; [email protected] Subject: Re:

Re: [10] RFR: JDK-8183310: java/security/modules/ModularTest.java should clean up better

2017-08-23 Thread Weijun Wang
Is there any reason why service being "true" and "false" are in 2 @run? This means setup() will run twice. --Max > On Aug 22, 2017, at 9:36 PM, Sibabrata Sahoo > wrote: > > Hi Max, > > Please find the updated webrev addressing all comments in applicable test > files. > > Webrev: http://cr.