On 2017-09-21 17:25, Adam Petcher wrote:
I would like to leave this open for feedback for another week or so.
Please reply with your comments by Saturday, September 30, end of day,
anywhere on earth. After that time, I plan to move on to the next phase
of the process (group lead and architect rev
> On Sep 22, 2017, at 8:37 AM, Xuelei Fan wrote:
>
> Looks good.
Thanks. I'll wait for the test passing and push the change.
>
> There are some wired Krb5 modules dependency even Krb5 is not used at all in
> the testing. Anyway, we may want an improvement in the future.
My fix this time is
Looks good.
There are some wired Krb5 modules dependency even Krb5 is not used at
all in the testing. Anyway, we may want an improvement in the future.
Thanks,
Xuelei
On 9/21/2017 5:25 PM, Weijun Wang wrote:
Hi All
I'm very sorry that my earlier change for JDK-8186884 made a lot of DTLS te
Hi All
I'm very sorry that my earlier change for JDK-8186884 made a lot of DTLS test
failing. A new @modules tag was added to JGSS/krb5 tests, but I didn't realize
DTLS tests are also using it.
Please take a review at
http://cr.openjdk.java.net/~weijun/8187786/webrev.00/
It's quite long, b
> On Sep 22, 2017, at 6:06 AM, Rob McKenna wrote:
>
> Thanks Xuelei, webrev below:
>
> http://cr.openjdk.java.net/~robm/8184328/webrev.02/
>
Looks fine to me.
> Presumably this won't require a CSR?
>
Agreed.
Xuelei
>-Rob
>
>> On 15/09/17 04:38, Xuelei Fan wrote:
>> I still prefer to
Thanks Xuelei, webrev below:
http://cr.openjdk.java.net/~robm/8184328/webrev.02/
Presumably this won't require a CSR?
-Rob
On 15/09/17 04:38, Xuelei Fan wrote:
> I still prefer to not-depends on socket receiving timeout. But I'm fine if
> you want to move on with it.
>
> As we can close t
Thank you for reviewing this.
- Amanda
On 9/20/17 6:33 PM, Xuelei Fan wrote:
Looks fine to me.
Thanks,
Xuelei
On 9/20/2017 4:52 PM, Amanda Jiang wrote:
Hi All,
Please help to review following webrev for fixing a test issue:
Bug: https://bugs.openjdk.java.net/browse/JDK-8176354
webrev: ht
I would like to leave this open for feedback for another week or so.
Please reply with your comments by Saturday, September 30, end of day,
anywhere on earth. After that time, I plan to move on to the next phase
of the process (group lead and architect review prior to submission).
On 9/14/201
