> On Dec 14, 2017, at 5:18 AM, Sean Mullan wrote:
>
> Looks good, but just to confirm something -- when verifying, if the signer's
> certificate chain is still valid and unexpired, then an expired or invalid
> timestamp or chain should not be an error. Essentially, the validation of the
> ti
Looks good, but just to confirm something -- when verifying, if the
signer's certificate chain is still valid and unexpired, then an expired
or invalid timestamp or chain should not be an error. Essentially, the
validation of the timestamp should only be done when the signer's
certificate chain
Thank you Sean for review!
On 12/13/17 11:00 AM, Sean Mullan wrote:
Looks fine to me.
--Sean
On 12/13/17 1:02 PM, Ivan Gerasimov wrote:
Ping!
The patch is the anti-delta of the fixes, so we're just reverting to
what we used to have prior these fixes.
Would you please help review this and
Looks fine to me.
--Sean
On 12/13/17 1:02 PM, Ivan Gerasimov wrote:
Ping!
The patch is the anti-delta of the fixes, so we're just reverting to
what we used to have prior these fixes.
Would you please help review this and approve the backport?
With kind regards,
Ivan
On 12/11/17 9:30 AM,
Ping!
The patch is the anti-delta of the fixes, so we're just reverting to
what we used to have prior these fixes.
Would you please help review this and approve the backport?
With kind regards,
Ivan
On 12/11/17 9:30 AM, Ivan Gerasimov wrote:
Hello!
I'm seeking an approval to backport thi
> On Dec 13, 2017, at 11:36 PM, Sean Mullan wrote:
>
> It looks like you converted p12importks.sh from shell code to java in
> JKStoPKCS12.java, right?
Yes, and modified a little.
> I think you should still include 8010125 in the @bug label in
> JKStoPKCS12.java though.
OK.
>
> Otherwise
It looks like you converted p12importks.sh from shell code to java in
JKStoPKCS12.java, right? I think you should still include 8010125 in the
@bug label in JKStoPKCS12.java though.
Otherwise, looks good, one question though:
If you are converting a JKS keystore to a PKCS12 keystore using keyt
All suggestions accepted. Here is an updated webrev.
http://cr.openjdk.java.net/~weijun/8191438/webrev.01/
New test cases added. Other changes are:
1. noTimestamp == true at signing side means no TSA or timestamping failed.
2. New method certsAndTSInfo() used by both signing and verification
