RFR JDK-8189760: sun/security/ssl/CertPathRestrictions/TLSRestrictions.java failed with unexpected Exception intermittently

2018-01-03 Thread sha . jiang
Hi, The server side exception is used to determine the test result status for some cases, but because of concurrency issue, the exception possibly is not available. This patch is expected to fix this issue. Webrev: http://cr.openjdk.java.net/~jjiang/8189760/webrev.00/ Issue: https://bugs.openjd

RFR 8191438: jarsigner should print when a timestamp will expire

2018-01-03 Thread Weijun Wang
Please take a review at http://cr.openjdk.java.net/~weijun/8191438/webrev.04/ Major changes: 1. Warnings on TSA cert chain: expired or expiring 2. No more check on trusted certs 3. More output at signing when -verbose is on 4. Fine tune messages when TSA cert expires earlier than signer cer

Re: Code Review Request, JDK-8185576 : New handshake implementation

2018-01-03 Thread Jamil Nimeh
Hi Xuelei, I'm only part way through this but I wanted to give you what I had so far. I'm working on the new files now so hopefully I'll have the rest of them done tomorrow. * CipherBox.java o 146: Were you intending to leave that commented protocol version line in there in the s

Re: API review for X25519/X448

2018-01-03 Thread Adam Petcher
+core-libs-dev (to get some additional API guidance) On 1/3/2018 11:26 AM, Adam Petcher wrote: Now that the JEP[1] for X25519/X448 key agreement is a candidate, we can proceed with the API and specification review. Please review the proposed API spec[2] and provide comments by the end of Satur

Re: API review for X25519/X448

2018-01-03 Thread Anders Rundgren
On 2018-01-03 17:26, Adam Petcher wrote: Since this is quite similar to what I proposed some 6 month ago https://github.com/cyberphone/java-cfrg-spec I can only give it a +100 :-) Cheers, Anders now looking forward to the signature support. Now that the JEP[1] for X25519/X448 key agreement is

API review for X25519/X448

2018-01-03 Thread Adam Petcher
Now that the JEP[1] for X25519/X448 key agreement is a candidate, we can proceed with the API and specification review. Please review the proposed API spec[2] and provide comments by the end of Saturday,  January 13, anywhere on earth. At that point, I will combine your feedback with the initia

Re: [8u-dev] Request to Review and for Approval to Backport 8192987 : keytool should remember real storetype if it is not provided

2018-01-03 Thread Seán Coffey
Looks fine. Approved for jdk8u-dev. regards, Sean. On 03/01/2018 02:44, Weijun Wang wrote: The code change looks fine to me. Thanks Max On Jan 3, 2018, at 9:16 AM, Ivan Gerasimov wrote: Hello! I'd like to backport this fix to JDK 8u-dev. The patch did NOT apply cleanly, thus a Review re