> On Jan 11, 2018, at 1:30 PM, Sibabrata Sahoo
> wrote:
>
> I will remove the commented lines. I think, it should be fine, if I do not
> submit the webrev again.
Not necessary at all.
--Max
>
> Thanks,
> Siba
>
> -Original Message-
> From: Weijun Wang
> Sent: Wednesday, January
I will remove the commented lines. I think, it should be fine, if I do not
submit the webrev again.
Thanks,
Siba
-Original Message-
From: Weijun Wang
Sent: Wednesday, January 10, 2018 9:07 PM
To: Sibabrata Sahoo
Cc: [email protected]
Subject: Re: [11] RFR: 8194486: Several
The class spec of SignedObject.java [1] contains:
* {@code
* Signature signingEngine = Signature.getInstance(algorithm,
* provider);
* SignedObject so = new SignedObject(myobject, signingKey,
*signingEngine);
* }
.
Hello Xuelei,
Here are a few more comments from some of the new files, maybe one or
two existing ones that I missed the first time around. I still need to
do the final two big ones (SSLSocketImpl and SSLEngineImpl), but I think
I've gone through every other file in the webrev at this point.
Code change looks fine. I think you can safely remove the lines commented out.
If you meant to keep the history, the Mercurial repo already had it.
Thanks
Max
> On Jan 10, 2018, at 8:58 PM, Sibabrata Sahoo
> wrote:
>
> Hi,
>
> Please review the change for the following patch,
>
> JBS: htt
Hi,
Please review the change for the following patch,
JBS: https://bugs.openjdk.java.net/browse/JDK-8194486
Webrev: http://cr.openjdk.java.net/~ssahoo/8194486/webrev.00/
Description:
There are several failure occurred recently because the name service used by
these Tests were not det
Hi,
JDK-8186098 is raised due to the NSS lib version cannot be determined
from the lib content.
When this issue occurs, it would be better to output the parsed content
for further investigation.
Webrev: http://cr.openjdk.java.net/~jjiang/8194864/webrev.00/
Issue: https://bugs.openjdk.java.net/
