Re: [PATCH]: Support for brainpool curves from CurveDB in SunEC

I applied your patch and ran some initial tests, and everything looks good so far. I'm running the the regression tests on all platforms, and I'll let you know how it goes. We need a JDK Reviewer to review and approve the code, so I'm hoping someone will volunteer to take a look. For the

Update mechanism for the upcoming trust store

Hello everybody, I am watching the effort of the community to create a new trust store (JEP319). Based on the description, a trust store will be created which will be shipped with every release. I think that this is a really good step, however I believe that a different approach should be used,

Re: Code Review Request, JDK-8185576 : New handshake implementation

Disclaimer: I am not a Reviewer. This is not a Review. I looked through all of the code and I didn't find any significant issues. In general, I think this is a nice improvement, and it makes the code easier to understand. Below are a few minor comments: SupportedGroups.java: There are

Re: RFR [10]: 8194307: KeyStore#getInstance with custom LoadStoreParameter succeeds with invalid password

On 1/18/18 5:54 AM, Weijun Wang wrote: The code change looks fine to me. Thanks. Do you mean that getInstance(File, LoadStoreParameter) should have never been invented because a static password should always be enough for a static file? Yes. I think we should have added getInstance(File,

Re: RFR [10]: 8194307: KeyStore#getInstance with custom LoadStoreParameter succeeds with invalid password

The code change looks fine to me. Do you mean that getInstance(File, LoadStoreParameter) should have never been invented because a static password should always be enough for a static file? Thanks Max > On Jan 18, 2018, at 6:36 AM, Sean Mullan wrote: > > Please review