Looks fine to me.
--Sean
On 1/24/18 10:53 PM, Weijun Wang wrote:
Please take a review at
http://cr.openjdk.java.net/~weijun/8177398/webrev.00/
Dotfiles will not be included in "includedir" of krb5.conf.
Thanks
Max
You Hello,
The spec should most likely mention AAD data as well and the 12 Byte size of
the nonce. And that the plaintext Limit is in blocks (and the AAD Limit is a
64Bit counter)
(And yes there is no wrapping to be found, not even in RFC 8103 which discusses
key transport,)
Does it need to
On 1/25/2018 11:45 AM, Adam Petcher wrote:
On 1/25/2018 12:20 PM, Jamil Nimeh wrote:
Wrap and Unwrap: I have not been able to find a standardized
wrap/unwrap format for ChaCha20 similar to RFC 3394 for AES. Right
now the wrap() and unwrap() methods just take the encoding of the key
to be
On 1/25/2018 12:20 PM, Jamil Nimeh wrote:
Wrap and Unwrap: I have not been able to find a standardized
wrap/unwrap format for ChaCha20 similar to RFC 3394 for AES. Right now
the wrap() and unwrap() methods just take the encoding of the key to
be wrapped and encrypts or decrypts them
Hello all,
This is a proposal to introduce the ChaCha20 and ChaCha20-Poly1305
cipher implementations into JDK. At a high level, the plan is to
include both ChaCha20-Poly1305 and the base ChaCha20 stream cipher into
JDK as part of the SunJCE provider initially, and then add TLS cipher
suites
On 1/24/2018 11:14 PM, Weijun Wang wrote:
The change looks fine.
+1
Xuelei
Thanks
Max
On Jan 25, 2018, at 1:52 PM, sha.ji...@oracle.com wrote:
Hi Max, Xuelei,
Please review this updated patch:
http://cr.openjdk.java.net/~jjiang/8186098/webrev.01/
Both of your suggestions are addressed.
