[8u] [RFR] Request for Review of JDK-8196952: Bad primeCertainty value setting in DSAParameterGenerator

2018-02-21 Thread Andrew Hughes
Bug: https://bugs.openjdk.java.net/browse/JDK-8196952 Webrev: http://cr.openjdk.java.net/~andrew/openjdk8/8196952/webrev.01/ Review thread: N/A When merging the recent 8u161 update into IcedTea, I came across a merge issue related to the ordering of changes to DSAParameterGenerator. It's an issue

Re: [PATCH] JDK-8194630: Uninitialized initiator_address in native GSS

2018-02-21 Thread Valerie Peng
I have this on my to-do-list and will include this for the next release, JDK 11, whose release date is Nov this year. Thanks, Valerie On 2/21/2018 8:39 AM, Jan Kalina wrote: I has prepared fix for bug related to using native GSS API. Uninitialized fields causes JVM crash or authentication faili

Re: [PATCH] JDK-8194630: Uninitialized initiator_address in native GSS

2018-02-21 Thread Martin Balao
Have you considered zeroizing the whole "gss_channel_bindings_t" structure with memset? So we don't have problem if new fields are eventually added. On Wed, Feb 21, 2018 at 1:39 PM, Jan Kalina wrote: > I has prepared fix for bug related to using native GSS API. > Uninitialized fields causes JVM

[PATCH] JDK-8194630: Uninitialized initiator_address in native GSS

2018-02-21 Thread Jan Kalina
I has prepared fix for bug related to using native GSS API. Uninitialized fields causes JVM crash or authentication failing. Bug consequences are more described in bugreport: https://bugs.openjdk.java.net/browse/JDK-8194630 Reproducer is attached to bugreport too. Would anyone be interested in re

Re: Code Review Request: TLS 1.3 full handshake (JDK-8196584)

2018-02-21 Thread Xuelei Fan
Thanks for the feed back. It's good enough to get KRB5 cipher suites back. Regards, Xuelei On 2/21/2018 5:06 AM, David Lloyd wrote: On Tue, Feb 20, 2018 at 1:57 PM, Xuelei Fan wrote: In this implementation, I removed: 1. the KRB5 cipher suite implementation. Please let me know if you are sti

Re: Code Review Request: TLS 1.3 full handshake (JDK-8196584)

2018-02-21 Thread David Lloyd
On Tue, Feb 20, 2018 at 1:57 PM, Xuelei Fan wrote: > In this implementation, I removed: > 1. the KRB5 cipher suite implementation. > Please let me know if you are still using KRB5 cipher suite. I may not add > them back if no objections. I am given to understand that we have multiple users using