Re: RFR: JDK-8200178 Remove mapfiles for JDK native libraries

2018-03-28 Thread Martin Buchholz
On Wed, Mar 28, 2018 at 3:14 PM, Magnus Ihse Bursie < magnus.ihse.bur...@oracle.com> wrote: > On 2018-03-28 23:53, Martin Buchholz wrote: > > I can't find any documentation for what JNIEXPORT and friends actually do. > People including myself have been cargo-culting JNIEXPORT and JNICALL for > dec

Re: RFR: JDK-8200178 Remove mapfiles for JDK native libraries

2018-03-28 Thread Magnus Ihse Bursie
On 2018-03-28 23:53, Martin Buchholz wrote: I can't find any documentation for what JNIEXPORT and friends actually do. People including myself have been cargo-culting JNIEXPORT and JNICALL for decades. Why aren't they in the JNI spec? That surprises me. I'm quite certain that javah (or rather,

Re: RFR: JDK-8200178 Remove mapfiles for JDK native libraries

2018-03-28 Thread Martin Buchholz
I can't find any documentation for what JNIEXPORT and friends actually do. People including myself have been cargo-culting JNIEXPORT and JNICALL for decades. Why aren't they in the JNI spec? --- It's fishy that the attribute externally_visible (which seems very interesting!) is ARM specific. #

Re: RFR: JDK-8200178 Remove mapfiles for JDK native libraries

2018-03-28 Thread Erik Joelsson
Build changes still look good to me. /Erik On 2018-03-28 03:31, Magnus Ihse Bursie wrote: On 2018-03-28 01:52, Weijun Wang wrote: On Mar 24, 2018, at 6:03 AM, Magnus Ihse Bursie wrote: https://bugs.openjdk.java.net/browse/JDK-8200193 -- for jdk.security.auth There is only one function t

Re: Comment on https://bugs.openjdk.java.net/browse/JDK-8145252 - TLS 1.3 formally adopted by IETF

2018-03-28 Thread Sean Mullan
I also made a similar change to the Risks and Assumptions section of the JEP. --Sean On 3/28/18 3:47 PM, Bradford Wetmore wrote: On 3/28/2018 11:46 AM, R Wagner wrote: I was wondering if it was possible to update this issue and make a comment that TLS 1.3 has been formally adopted. I just

Re: Comment on https://bugs.openjdk.java.net/browse/JDK-8145252 - TLS 1.3 formally adopted by IETF

2018-03-28 Thread Bradford Wetmore
On 3/28/2018 11:46 AM, R Wagner wrote: I was wondering if it was possible to update this issue and make a comment that TLS 1.3 has been formally adopted. I just added a quick comment. > See: IETF approves TLS 1.3 Just FYI: the TLS 1.3 spec[1] still has a few more steps to go before it i

Comment on https://bugs.openjdk.java.net/browse/JDK-8145252 - TLS 1.3 formally adopted by IETF

2018-03-28 Thread R Wagner
I was wondering if it was possible to update this issue and make a comment that TLS 1.3 has been formally adopted. See: IETF approves TLS 1.3 Announcement https://www.ietf.org/mail-archive/web/ietf-announce/current/msg17592.html Article https://www.bleepingcomputer.com/news/security/ietf-

Re: -Djava.security.manager=problems for service providers

2018-03-28 Thread Peter Firmstone
I tested the JDK 9 pre releases and didn't experience issues, will have to test again against the latest. Note on JDK1.8.0_162 it doesn't only affect the PolicyFile provider. Thanks, Peter. On 27/03/2018 11:06 PM, Alan Bateman wrote: Moving this to security-dev. From the stack trace, it l

Re: RFR: ChaCha20 and ChaCha20/Poly1305 Cipher implementations

2018-03-28 Thread Jamil Nimeh
I think I could pull in Convert.hexStringToByteArray.  I might try pulling in that test class locally just to make sure things still run before you commit the field arithmetic stuff.  I also noticed I left in some debug routines in ChaCha20Cipher that need to get the axe, so I'll cut those out

Re: RFR: ChaCha20 and ChaCha20/Poly1305 Cipher implementations

2018-03-28 Thread Adam Petcher
On 3/28/2018 2:48 AM, sha.ji...@oracle.com wrote: Would you like to move this method to a test lib class, like test/lib/jdk/test/lib/Utils.java? In fact, this class has a method, named toHexString, for converting bin to hex. This method appears to be the same as Convert.hexStringToByteArray t

Re: RFR: JDK-8200178 Remove mapfiles for JDK native libraries

2018-03-28 Thread Magnus Ihse Bursie
On 2018-03-28 01:52, Weijun Wang wrote: On Mar 24, 2018, at 6:03 AM, Magnus Ihse Bursie wrote: https://bugs.openjdk.java.net/browse/JDK-8200193 -- for jdk.security.auth There is only one function to export and it already has JNIEXPORT, so you can just remove the new $(LIBJAAS_CFLAGS) [1].