Please find comments in line.
On 5/18/2018 4:29 PM, Bradford Wetmore wrote:
Mostly minor, but a couple substantive comments.
I skimmed the tests this time, but didn't hit them as hard.
On 5/14/2018 1:20 PM, Valerie Peng wrote:
Hi Brad,
The latest webrev is at
http://cr.openjdk.java.net/~val
Hi John,
Yes, the second call must throw IllegalStateException. See the class
description in javax.crypto.Cipher where it talks about AEAD modes and
AAD processing. It states that all AAD has to be supplied before update
and/or doFinal methods are invoked. This constraint is also talked
ab
Mostly minor, but a couple substantive comments.
I skimmed the tests this time, but didn't hit them as hard.
On 5/14/2018 1:20 PM, Valerie Peng wrote:
Hi Brad,
The latest webrev is at
http://cr.openjdk.java.net/~valeriep/8146293/webrev.04/
The only difference between webrev.03 and webrev.04 i
Hi Jamil,
-- ChaCha20Cipher.java
430 } else if (aadDone) {
431 // No AAD updates allowed after the PT/CT update
method is called
432 throw new IllegalStateException("Attempted to update
AAD on " +
433 "Cipher after plaintext/ciphertext u
On 5/17/18 1:54 AM, Shubham Rajput wrote:
Any lead why the signature is forming for the node element name only and
not for the whole node?
I can't remember for sure now, but it probably has something to do with
the way you are returning the nodes from your URIDereferencer.
You are probably
