Re: Inconsistent SSLEngine behavior for closing outbound while in handshake in 11ea22

Yes. I can test once there is a patch. My inquiry was motivated by some work on Elasticsearch fyi. I can test a patch against that work. https://github.com/elastic/elasticsearch/issues/32144 - Tim > On Jul 17, 2018, at 8:40 PM, Xuelei

Re: RFR[11] JDK-8206171: Signature#getParameters for RSASSA-PSS throws ProviderException when not initialized

Sean, Where do you think that we should add the part about "null must be returned ..." paragraph? At the end of first or second paragraph? I will go with majority. Valerie On 7/17/2018 8:38 PM, Weijun Wang wrote: Is it better to append the new lines to the 2nd paragraph? Thanks Max On

Re: [11] RFR 8202837: PBES2 AlgorithmId encoding error in PKCS12 KeyStore

Looks fine to me except a minor nit. PBES2Parameters.java: - 282 String kdfAlgo = "HmacSHA1"; // default I may suggest you move the declaration down to line 314. It is clear about what the "default" means. Xuelei On 7/18/2018 1:57 AM, Weijun Wang wrote: Please

Re: RFR 8207250: setUseClientMode post handshake with the same value as before does not throw IAE

Looks fine to me. Thanks, Xuelei On 7/18/2018 12:25 AM, Weijun Wang wrote: Please take a review at JBS: https://bugs.openjdk.java.net/browse/JDK-8207250 Fix: http://cr.openjdk.java.net/~weijun/8207250/webrev.00/ The status check should be performed no matter what the argument is.

Re: RFR: 8203230: update VerifyCACerts tests

Looks fine. --Sean On 7/17/18 8:31 PM, Rajan Halade wrote: Please review this update for VerifyCACerts test to remove dependency on OpenJDK build. @@ -25,7 +25,6 @@  /**   * @test   * @bug 8189131 8198240 8191844 8189949 8191031 8196141 8204923 8195774 8199779 - *

[11] RFR 8202837: PBES2 AlgorithmId encoding error in PKCS12 KeyStore

Please take a review at JBS: https://bugs.openjdk.java.net/browse/JDK-8202837 Fix: http://cr.openjdk.java.net/~weijun/8202837/webrev.00/ The redundant encoding/decoding of the extra PBES2 OID is removed. The encoding/decoding of keyLength and prf in PBKDF2-params is also made

RFR 8207250: setUseClientMode post handshake with the same value as before does not throw IAE

Please take a review at JBS: https://bugs.openjdk.java.net/browse/JDK-8207250 Fix: http://cr.openjdk.java.net/~weijun/8207250/webrev.00/ The status check should be performed no matter what the argument is. Thanks Max