Re: RFR JDK-8029661: JDK-Support TLS v1.2 algorithm in SunPKCS11 provider

Hi Martin, Sorry for the delay, I am able to resume on reviewing this now. Here are some initial comments. What about CKM_TLS12_MAC? I see that it's defined under TLS 1.2 mechanisms, but not much other details for it. - Is this change still necessary? I didn't notice any new import stateme

Re: RFR[11] JDK-8206171: Signature#getParameters for RSASSA-PSS throws ProviderException when not initialized

Something related. Cipher has a similar init(..,params) and getParameters() structure and the spec is also similar. * The returned parameters may be the same that were used to initialize * this cipher, or may contain a combination of default and random * parameter values used by the underlying c

Re: RFR[11] JDK-8206171: Signature#getParameters for RSASSA-PSS throws ProviderException when not initialized

Returning to this briefly, looks good to me too. Brad On 7/19/2018 6:23 PM, Valerie Peng wrote: Thanks Max and Sean for the review and suggestions. I have updated the webrev accordingly and finalized CSR. Webrev: http://cr.openjdk.java.net/~valeriep/8206171/webrev.04/ CSR: https://bugs.open

RFR 8076190: Support passwordless access to PKCS12 keystores

Please review the code change and CSR at webrev: http://cr.openjdk.java.net/~weijun/8076190/webrev.01/ CSR: https://bugs.openjdk.java.net/browse/JDK-8202590 The bug is at https://bugs.openjdk.java.net/browse/JDK-8076190 This is the 1st part of the process to make cacerts using pkcs12: