Re: Inconsistent SSLEngine behavior for closing outbound while in handshake in 11ea22

2018-08-09 Thread Xuelei Fan
Thank you, Tim! Please feel free to submit bugs and comments. Xuelei On 8/9/2018 4:23 PM, Tim Brooks wrote: Hi Xuelei, My test passed using that patch. I’ll continue to explore over the next few days. But that patch resolves the main issues that I had encountered. Thanks, - Tim On Aug 7

Re: Inconsistent SSLEngine behavior for closing outbound while in handshake in 11ea22

2018-08-09 Thread Tim Brooks
Hi Xuelei, My test passed using that patch. I’ll continue to explore over the next few days. But that patch resolves the main issues that I had encountered. Thanks, - Tim > On Aug 7, 2018, at 8:54 AM, Xuelei Fan wrote: > > Xuelei

Re: RFR 8201290: keytool importcert fails with CertificateParsingException if unknown certificate algorithms should be imported

2018-08-09 Thread Sean Mullan
On 8/7/18 11:53 PM, Weijun Wang wrote: On Aug 8, 2018, at 12:58 AM, Sean Mullan wrote: On 8/6/18 8:20 PM, Weijun Wang wrote: I'm not seeing how this would be a behavior change if it is a new option, can you add more details on that? If I specify -providerName, intuitively I would expect i

Re: JDK 12 RFR of JDK-8209024: Use SuppressWarnings -- now RFR for 8209304: Deprecate serialVersionUID fields in interfaces

2018-08-09 Thread joe darcy
Hi Alan, On 8/6/2018 11:12 PM, Alan Bateman wrote: On 06/08/2018 20:11, joe darcy wrote: Hello, Various interfaces in the JDK extend Serializable and declare serialVersionUID fields. Such fields are ineffectual and @SuppressWarnings("serial") should be applied to such fields to suppress f

Re: Feedback on EdDSA API

2018-08-09 Thread Adam Petcher
On 8/9/2018 1:17 PM, Sean Mullan wrote: A few (mostly minor) comments on the Solution section. I'll continue my review of the rest of the CSR later. First sentence, "from the existing API ECDSA ..." should that be "API for ECDSA"? // example: use KeyFactory to contruct a public key typo: c

Re: Feedback on EdDSA API

2018-08-09 Thread Sean Mullan
A few (mostly minor) comments on the Solution section. I'll continue my review of the rest of the CSR later. First sentence, "from the existing API ECDSA ..." should that be "API for ECDSA"? // example: use KeyFactory to contruct a public key typo: construct "This API does not standardize "

Re: Code Review Request, JDK-8208166, Still unable to use custom SSLEngine with default TrustManagerFactory after JDK-8207029

2018-08-09 Thread Xuelei Fan
I'm waiting for the CSR approval for JDK 11: https://bugs.openjdk.java.net/browse/JDK-8208526 Thanks, Xuelei On 8/9/2018 6:50 AM, Norman Maurer wrote: I there any idea when the patch will be merged and a release will be cut so we can enable testing with JDK11 again for netty ? On 31. Jul 20

Re: Code Review Request, JDK-8208166, Still unable to use custom SSLEngine with default TrustManagerFactory after JDK-8207029

2018-08-09 Thread Norman Maurer
I there any idea when the patch will be merged and a release will be cut so we can enable testing with JDK11 again for netty ? > On 31. Jul 2018, at 07:19, Norman Maurer wrote: > > After digging more this morning I noticed the test code did made some wrong > assumptions which just worked out

Re: CSR Review: 8208641: SSLSocket should throw an exception when configuring DTLS

2018-08-09 Thread Xuelei Fan
On 8/9/2018 4:25 AM, Sean Mullan wrote: On 8/8/18 5:29 PM, Xuelei Fan wrote: The "Default" algorithm defined in the SunJSSE provider is for TLS protocols. What if I set DTLS to be the default, though? Ex:     SSLContext.setDefault(SSLContext.getInstance("DTLS")); Good point! Maybe, we also

Re: CSR Review: 8208641: SSLSocket should throw an exception when configuring DTLS

2018-08-09 Thread Sean Mullan
On 8/8/18 5:29 PM, Xuelei Fan wrote: The "Default" algorithm defined in the SunJSSE provider is for TLS protocols. What if I set DTLS to be the default, though? Ex: SSLContext.setDefault(SSLContext.getInstance("DTLS")); --Sean Xuelei On 8/8/2018 1:28 PM, Sean Mullan wrote: On 8/8/18

RFR: JDK-8209129 :Further improvements to cipher buffer management

2018-08-09 Thread Seán Coffey
Adding RFR to title.. On 09/08/2018 11:37, Seán Coffey wrote: I've been looking further at how private/temporary buffers are used in cipher/keystore management and identified some more areas that could benefit with a more aggressive nulling out of contents. I've been testing through use of st

JDK-8209129 :Further improvements to cipher buffer management

2018-08-09 Thread Seán Coffey
I've been looking further at how private/temporary buffers are used in cipher/keystore management and identified some more areas that could benefit with a more aggressive nulling out of contents. I've been testing through use of stepping through debugging sessions while setting/getting keys an

Re: RFR 8076190: Support passwordless access to PKCS12 keystores

2018-08-09 Thread Weijun Wang
Webrev updated at http://cr.openjdk.java.net/~weijun/8076190/webrev.02 The only change is in keytool/Main and the test. keytool will not prompt for store password if it detects a password-less keystore. This is 3) below. Thanks Max > On Jul 24, 2018, at 6:49 PM, Weijun Wang wrote: > > Pl

Re: [RFR] 8205525 : Improve exception messages during manifest parsing of jar archives

2018-08-09 Thread Chris Hegarty
Matthias, > On 9 Aug 2018, at 08:07, Baesken, Matthias wrote: > >> Did we get to a conclusion on whether to have central infrastructure to >> read/parse the security property? As I recall, this one was originally >> proposed before the generalization of the networking solution. There are >> deta

Re: CSR Review: 8208641: SSLSocket should throw an exception when configuring DTLS

2018-08-09 Thread Chris Hegarty
Ok, thanks. Looks like the “Default” case is not-an-issue. -Chris. > On 8 Aug 2018, at 22:29, Xuelei Fan wrote: > > The "Default" algorithm defined in the SunJSSE provider is for TLS protocols. > > Xuelei > > On 8/8/2018 1:28 PM, Sean Mullan wrote: >> On 8/8/18 1:58 PM, Anthony Scarpino wrote

RE: [RFR] 8205525 : Improve exception messages during manifest parsing of jar archives

2018-08-09 Thread Baesken, Matthias
> Did we get to a conclusion on whether to have central infrastructure to > read/parse the security property? As I recall, this one was originally > proposed before the generalization of the networking solution. There are > details related to trimming that would be better not to duplicate if > poss