Re: RFR[11]: release note for JDK-7007966 "Add Brainpool ECC support (RFC 5639)"

2018-08-16 Thread Valerie Peng
Sure, I've updated the release note. Please let me know if you have other suggestions/feedbacks. https://bugs.openjdk.java.net/browse/JDK-8208580 Thanks, Valerie On 8/16/2018 8:10 AM, Adam Petcher wrote: This is in JCA only, and not yet integrated into SunJSSE, right? Either way, I thin

Re: JDK 12 RFR of JDK-8209024: Use SuppressWarnings -- now RFR for 8209304: Deprecate serialVersionUID fields in interfaces

2018-08-16 Thread Joseph D. Darcy
Hi Sean, On 8/15/2018 1:32 PM, Sean Mullan wrote: On 8/9/18 2:36 PM, joe darcy wrote: Security libs team, for src/java.base/share/classes/sun/security/internal/interfaces/TlsMasterSecret.java I added a separate @Deprecated annotation for the serialVersionUID field even though the interfac

Re: RFR 6913047: SunPKCS11 memory leak

2018-08-16 Thread Valerie Peng
Hi Martin, Since there is no regression test for this test, you will need to add a "noreg-xxx" label to the bug record. For this issue, it'll probably be "noreg-hard". To understand the changes better, please find my questions and some review comments below: - line 397: It's incorrect to

Re: RFR: JDK-8209129 :Further improvements to cipher buffer management

2018-08-16 Thread Seán Coffey
Find new webrev here Max : http://cr.openjdk.java.net/~coffeys/webrev.8209129.v2/webrev/ regards : MD4.java:   110 void implReset() {   Add @Override. There's a whole bunch of annotations missing in these files, I'd prefer if it was fixed up with different bug ID. another thing we're

Re: RFR[11]: release note for JDK-7007966 "Add Brainpool ECC support (RFC 5639)"

2018-08-16 Thread Adam Petcher
This is in JCA only, and not yet integrated into SunJSSE, right? Either way, I think it would be helpful to add a sentence saying whether these curves are supported in SunJSSE. I expect that people will wonder about this when reading the release note. On 8/15/2018 7:02 PM, Valerie Peng wrote: