Re: NPE in SupportedGroupsExtension

2018-09-12 Thread Bradford Wetmore
We finally found what I think are the 2018-09-08 nightly builds. https://download-origin.cdn.mozilla.net/pub/firefox/nightly/2018/09/ specifically: https://download-origin.cdn.mozilla.net/pub/firefox/nightly/2018/09/2018-09-08-10-04-02-mozilla-central/firefox-64.0a1.en-US.win64.installer.exe M

Re: NPE in SupportedGroupsExtension

2018-09-12 Thread Bradford Wetmore
Thomas, >> i found another bug with firefox nigthly "64.0a1 (2018-09-08) >> (64-bit)" and "OpenJDK Runtime Environment 18.9 (build 11+28)". Max/I are running a slightly later builds, 64.0a1 (2018-09-10) and (2018-09-12) respectively, and we're now seeing the psk_key_exchange_modes extension.

Re: SSL session cache default maximum number of entries

2018-09-12 Thread Hohensee, Paul
Thanks very much for investigating. We're aware that the cache size can be set by the user, but many of our users haven't done so because it hasn't been necessary, and boom. Paul On 9/11/18, 12:49 PM, "core-libs-dev on behalf of Sean Mullan" wrote: Hi Paul, Thank you for bring

Re: Code Review Request, JDK-8209916 : NPE in SupportedGroupsExtension

2018-09-12 Thread Thomas Lußnig
Hi, does the fix work if there is only one unknown named group ? Not that the connection fails than with an better error text instead of skiping the unknown group. Gruß Thomas On 12.09.2018 04:22:49, Xuelei Fan wrote: Hi Jamil, Would you please review the fix for the NPE issue:    http://cr

Java 11 RC - Handshake failure in certain specific cases throws a different exception than previous versions

2018-09-12 Thread Jaikiran Pai
Please consider the code that's at the end of this mail. It is a simple client/server code where a HTTPS server is created and set to "needClientAuth". The client then uses HttpsURLConnection and (in this case intentionally) doesn't present any certificate, expecting the handshake to fail. In previ

RE: [RFR] 8205525 : Improve exception messages during manifest parsing of jar archives

2018-09-12 Thread Langer, Christoph
Looks good to me. > -Original Message- > From: Baesken, Matthias > Sent: Mittwoch, 12. September 2018 11:27 > To: Sean Mullan ; Langer, Christoph > ; Weijun Wang > Cc: security-dev@openjdk.java.net; core-libs-...@openjdk.java.net > Subject: RE: [RFR] 8205525 : Improve exception messages d

Re: RFR JDK-8029661: JDK-Support TLS v1.2 algorithm in SunPKCS11 provider

2018-09-12 Thread Martin Balao
Hi Valerie, Thanks for your answer. Webrev.09: * http://cr.openjdk.java.net/~mbalao/webrevs/8029661/8029661.webrev.09/ * http://cr.openjdk.java.net/~mbalao/webrevs/8029661/8029661.webrev.09.zip In TestTLS12.java, we now capture any exception during initialization phase and skip test execution

RE: [RFR] 8205525 : Improve exception messages during manifest parsing of jar archives

2018-09-12 Thread Baesken, Matthias
Hello I changed it to jar , also added some minor adjustments suggested by Christoph . http://cr.openjdk.java.net/~mbaesken/webrevs/8205525.12/ Regards, Matthias > -Original Message- > From: Sean Mullan > Sent: Dienstag, 11. September 2018 20:44 > To: Langer, Christoph ; Baesken, Ma

RSACore$BlindingParameters not using user-provided SecureRandom

2018-09-12 Thread Weijun Wang
In src/java.base/share/classes/sun/security/rsa/RSACore.java: 353 BlindingParameters(BigInteger e, BigInteger d, BigInteger n) { 354 this.u = null; 355 this.v = null; 356 this.e = e; 357 this.d = d; 358 359