NPE during SSL handshake caused by HostnameChecker

2018-09-22 Thread Norman Maurer
Hi all, I think I found another bug in the the SSL implementation (well really in the TrustManager related part) which leads to a NPE. I was able to reproduce this on Java8 and Java11 (ea28) but I am sure it also exists on 9 and 10. While trying to write some test code for netty I did somethin

Re: RFR: JDK-8210918, Add test to exercise server-side client hello processing

2018-09-22 Thread Xuelei Fan
I like the updated test code. Thanks! Xuelei On 9/22/2018 11:33 AM, Jamil Nimeh wrote: Hi Brad, Xuelei, et al., Thanks for all your comments.  I've udpated the test with Brad's findings and made it use separate @run lines for each test as Xuelei requested. Webrev: http://cr.openjdk.java.n

Re: RFR: JDK-8210918, Add test to exercise server-side client hello processing

2018-09-22 Thread Jamil Nimeh
Hi Brad, Xuelei, et al., Thanks for all your comments.  I've udpated the test with Brad's findings and made it use separate @run lines for each test as Xuelei requested. Webrev: http://cr.openjdk.java.net/~jnimeh/reviews/8210918/webrev.02 --Jamil On 09/21/2018 02:35 PM, Jamil Nimeh wrote: