Re: RFR 8212003: Obsoleting the default keytool -keyalg option

2018-10-17 Thread Weijun Wang
> On Oct 18, 2018, at 10:34 AM, Weijun Wang wrote: > > Please review the code change and CSR for > > JBS: https://bugs.openjdk.java.net/browse/JDK-8212003 > > at > > webrev: http://cr.openjdk.java.net/~weijun/8212003/webrev.00/ > CSR: https://bugs.openjdk.java.net/browse/JDK-8212111

RFR 8212003: Obsoleting the default keytool -keyalg option

2018-10-17 Thread Weijun Wang
Please review the code change and CSR for JBS: https://bugs.openjdk.java.net/browse/JDK-8212003 at webrev: http://cr.openjdk.java.net/~weijun/8212003/webrev.00/ CSR: https://bugs.openjdk.java.net/browse/JDK-8212111 When -keyalg is not provided for -genkeypair or -genseckey, keytool wi

Re: RFR 8201355 : Avoid native memory allocation in sun.security.mscapi.PRNG.generateSeed

2018-10-17 Thread Weijun Wang
Looks fine to me. Thanks Max > On Oct 18, 2018, at 2:03 AM, Ivan Gerasimov wrote: > > Hello! > > In the function Java_sun_security_mscapi_PRNG_generateSeed() a native memory > is allocated, and then its content is copied into a freshly allocated Java > array. The native memory allocation ca

Re: RFR 8205476: KeyAgreement#generateSecret is not reset for ECDH based algorithm

2018-10-17 Thread Michael StJohns
On 10/17/2018 4:45 PM, Adam Petcher wrote: Webrev: http://cr.openjdk.java.net/~apetcher/8205476/webrev.00/ Bug: https://bugs.openjdk.java.net/browse/JDK-8205476 CSR: https://bugs.openjdk.java.net/browse/JDK-8212051 Please review the following change for a conformance bug in the ECDH service. Th

RFR 8205476: KeyAgreement#generateSecret is not reset for ECDH based algorithm

2018-10-17 Thread Adam Petcher
Webrev: http://cr.openjdk.java.net/~apetcher/8205476/webrev.00/ Bug: https://bugs.openjdk.java.net/browse/JDK-8205476 CSR: https://bugs.openjdk.java.net/browse/JDK-8212051 Please review the following change for a conformance bug in the ECDH service. The KeyAgreement is supposed to reset itself a

RFR 8201355 : Avoid native memory allocation in sun.security.mscapi.PRNG.generateSeed

2018-10-17 Thread Ivan Gerasimov
Hello! In the function Java_sun_security_mscapi_PRNG_generateSeed() a native memory is allocated, and then its content is copied into a freshly allocated Java array. The native memory allocation can be avoided, which also makes the code shorter. Would you please help review the fix? BUGURL

Re: Fluent builder API for JCA/JSSE classes

2018-10-17 Thread Weijun Wang
You can create a PKCS10 file, we have sun.security.pkcs.PKCS10. > On Oct 17, 2018, at 1:36 AM, Will Sargent wrote: > > Also, I wasn't able to figure out how to create CertificateRequest at all. > This is kind of a pain when dealing with Vault PKI or Lemur.

Re: RFR[12] JDK-8212562: To remove lib/security from test/jdk/TEST.groups

2018-10-17 Thread Seán Coffey
Looks fine to me. Regards, Sean. On 17/10/18 08:03, [email protected] wrote: Hi, test/jdk/lib/security doesn't exist, so this directory could be removed from jdk_security3 diff -r f54dcfc5a5f8 test/jdk/TEST.groups --- a/test/jdk/TEST.groupsFri Oct 05 15:12:37 2018 -0700 +++ b/test/jdk

Re: RFR: 8148188: Enhance the security libraries to record events of interest

2018-10-17 Thread Seán Coffey
I'd like to re-boot this review. I've been working with Erik off thread who's been helping with code and test design. Some of the main changes worthy of highlighting : * Separate out the tests for JFR and Logger events * Rename some events * Normalize the data view for X509ValidationEvent (old

RFR[12] JDK-8212562: To remove lib/security from test/jdk/TEST.groups

2018-10-17 Thread sha . jiang
Hi, test/jdk/lib/security doesn't exist, so this directory could be removed from jdk_security3 diff -r f54dcfc5a5f8 test/jdk/TEST.groups --- a/test/jdk/TEST.groups    Fri Oct 05 15:12:37 2018 -0700 +++ b/test/jdk/TEST.groups    Wed Oct 17 15:01:36 2018 +0800 @@ -218,8 +218,7 @@ -sun/securi