Test:
79: arf.yak.foo? Are you sure you don't want to use the new TLD .wtf
here? :)
97: You could request TLSv1.3 here, but what you have is fine since
you're hardcoding just the TLSv1.3 protocol later.
In other words, no real comments.
Brad
On 10/19/2018 11:18 AM, Xuelei Fan wrote
The copyrights should be updated. Otherwise, looks good.
--Sean
On 10/17/18 4:45 PM, Adam Petcher wrote:
Webrev: http://cr.openjdk.java.net/~apetcher/8205476/webrev.00/
Bug: https://bugs.openjdk.java.net/browse/JDK-8205476
CSR: https://bugs.openjdk.java.net/browse/JDK-8212051
Please review the
Looks fine to me.
Thanks,
Xuelei
On 10/19/2018 11:04 AM, Jamil Nimeh wrote:
Hello everyone,
I've added a test to go along with the bugfix. No changes to the actual
fix itself.
Updated webrev:
http://cr.openjdk.java.net/~jnimeh/reviews/8211806/webrev.02/
Thanks,
--Jamil
On 10/12/18 9:3
Hello everyone,
I've added a test to go along with the bugfix. No changes to the actual
fix itself.
Updated webrev:
http://cr.openjdk.java.net/~jnimeh/reviews/8211806/webrev.02/
Thanks,
--Jamil
On 10/12/18 9:39 PM, Jamil Nimeh wrote:
Hello all,
This addresses an issue where the client
Looks fine.
Regards,
Sean.
On 18/10/18 16:04, Sean Mullan wrote:
Please review this change to remove the GTE CyberTrust Global Root
from the cacerts keystore. This root is expired and all certificates
that chain back to this root have expired.
Note that retaining roots past their expiration
Hi Xin,
looks like a reasonable backport candidate for jdk8u. I guess the
changeset will apply cleanly once you correct the paths.
You should have no problem with a push request on jdk8u-dev :
http://openjdk.java.net/projects/jdk8u/approval-template.html
Regards,
Sean.
On 18/10/18 23:34, L
