Re: RFR: 8210838: Override javax.crypto.Cipher.toString()

Signature's toString looks like public String toString() { String initState = ""; switch (state) { case UNINITIALIZED: initState = ""; break; case VERIFY: initState = ""; break; case SIGN: initState = ""; break; } return "

Re: RFR 8212003: Obsoleting the default keytool -keyalg option

Would like also please review the release note here? https://bugs.openjdk.java.net/browse/JDK-8213965 I had thought about using RN-Deprecated but there is no API here. If you think it's better, I'll use it and also change all "obsolete" into "deprecate" in the description and title of the rel

Re: Code Review Request, JDK-8213577, Update the default SSL session cache size to 20480

Hi Sean, Are you OK if we do it later? I'm waiting for the @systemProperty tag, proposed within JDK-5076751. I will file a bug to use the tag for more cleanup. Thanks, Xuelei On 11/15/2018 11:55 AM, Sean Mullan wrote: This is a good opportunity to document the javax.net.ssl.sessionCacheSi

Re: Code Review Request, JDK-8213577, Update the default SSL session cache size to 20480

This is a good opportunity to document the javax.net.ssl.sessionCacheSize system property in the SSLSessionContext API (and use the new @systemProperty tag) in an @implNote, for example: /** * Returns the size of the cache used for storing * SSLSession objects grouped under this

RFR: 8210838: Override javax.crypto.Cipher.toString()

A simple enhancement to override toString() for javax.crypto.Cipher class https://bugs.openjdk.java.net/browse/JDK-8210838 webrev : http://cr.openjdk.java.net/~coffeys/webrev.8210838/webrev/ regards, Sean.

Re: FYI: new javadoc tag to document system properties

In JCE and JSSE, the public APIs definition (javax.net.ssl) and the internal implementation (sun.security.ssl) are separated. The system property can be defined in the internal implementation classes. I think we should add the @systemProperty on the public APIs, right? The public API class a

Re: RFR 8213009: Refactoring existing SunMSCAPI classes

Oops, my copy/paste sequence goes wrong. > On Nov 15, 2018, at 11:38 PM, Weijun Wang wrote: > > Webrev updated at > https://cr.openjdk.java.net/~weijun/8213009/webrev.01/ > > More refactorings: > > - getEncoded and getFormat of CKey removed, implemented in CPublicKey and > CPrivateKey.

Re: RFR 8213009: Refactoring existing SunMSCAPI classes

Webrev updated at Asserts.assertTrue(pr.getAlgorithm().equals("RSA")); More refactorings: - getEncoded and getFormat of CKey removed, implemented in CPublicKey and CPrivateKey. - CPublicKey has child class CRSAPublicKey, CKeyPairGenerator has child class RSA. - CPublicKey and CPrivateKey

Re: RFR 8213363: X25519 private key PKCS#8 encoding/decoding is incorrect

Done[1]. Please take a look when you have a chance. [1] https://bugs.openjdk.java.net/browse/JDK-8213946 On 11/14/2018 4:29 PM, Sean Mullan wrote: The fix and the CSR look good. Please also add a release note. --Sean On 11/8/18 11:51 AM, Adam Petcher wrote: Oops. And the JBS ticket: https://

Re: Problems with AES-GCM native acceleration

Hi all, Thanks for the prompt feedback on this stuff, appreciated. 1. Analytic queries are often interactive or one-off. A data scientist would get an on-demand notebook with a Spark cluster (spawned as a K8s pod), and run a number of queries. The cluster will be then closed either explicitly,