Re: RFR 6722928: Support SSPI as a native GSS-API provider

2018-11-20 Thread Weijun Wang
Thanks. I'll be very glad to hear your opinions are the handling of names. They are complicated. > On Nov 21, 2018, at 1:51 AM, Nico Williams wrote: > > On Tue, Nov 20, 2018 at 09:56:36AM +0800, Weijun Wang wrote: >> Please take a review at >> >> https://cr.openjdk.java.net/~weijun/6722928/w

Re: RFR: 8210838: Override javax.crypto.Cipher.toString()

2018-11-20 Thread Valerie Peng
I saw you've integrated this. Just want to add that, instead of mode (which is used also for part of the transformation, e.g. CBC, GCM), maybe we can use "operation" or "operating mode". Something to keep in mind for future changes, I guess. Regards, Valerie On 11/17/2018 11:36 PM, Weijun Wa

Re: RFR 6722928: Support SSPI as a native GSS-API provider

2018-11-20 Thread Nico Williams
On Tue, Nov 20, 2018 at 09:56:36AM +0800, Weijun Wang wrote: > Please take a review at > >https://cr.openjdk.java.net/~weijun/6722928/webrev.01/ > > We ported [1] the native GSS bridge to Windows in JDK 11, but user still have > to download and install a native GSS-API library. This code chan

Re: RFR 8210476: sun/security/mscapi/PrngSlow.java fails with Still too slow

2018-11-20 Thread Weijun Wang
Webrev updated at https://cr.openjdk.java.net/~weijun/8210476/webrev.01/ The only change is that there is a single Cleaner now for the whole PRNG class. Otherwise, each will maintain its own thread. Thanks Max > On Nov 11, 2018, at 11:30 PM, Weijun Wang wrote: > > Please take a review at