RE: downport of JDK-8209965 / JDK-8210005

2018-11-21 Thread Lindenmaier, Goetz
HI Rob, thanks for the update! Seems it was accepted for 11.0.2 ... So I don't need to take action. Best regards, Goetz. > -Original Message- > From: Rob McKenna > Sent: Mittwoch, 21. November 2018 17:35 > To: Lindenmaier, Goetz > Cc: security-dev@openjdk.java.net > Subject: Re: dow

Re: RFR 8213009: Refactoring existing SunMSCAPI classes

2018-11-21 Thread Valerie Peng
Hi Max, Here are some comments: - line 39, add PSS here as well. - line 97, CSignature ctr, better to initialize all fields - line 109, has key algorithm been checked by JCA already? If not, it should be checked here. Same goes for line 414, and 560 - with the class renaming, I think it's clea

RFR JDK-7092821 "java.security.Provider.getService() is synchronized and became scalability bottleneck"

2018-11-21 Thread Valerie Peng
Hi, Can someone help reviewing this fix? Besides changing the Provider class to use ConcurrentHashMap in order to reduce the lock contention on Provider.getService() calls, I also changed the security providers in java.base module to register through putService(...) calls. Performance is manu

Re: Problems with AES-GCM native acceleration

2018-11-21 Thread Andrew Haley
On 11/15/18 10:42 AM, Gidon Gershinsky wrote: > Having the decryption optimized in the HotSpot engine would be ideal. I agree with you. I did a few experiments, and it can take a very long time for C2 compilation to kick in, especially because GCM is glacially slow until the intrinsics are used.

Re: RFR: 8213952: Relax DNSName restriction as per RFC 1123

2018-11-21 Thread Seán Coffey
p.s I've updated the testcase to test the IOException message for presence of "DNSName". Webrev updated in place. Regards, Sean. On 21/11/18 15:42, Seán Coffey wrote: Thanks for the comments Bernd. Comments inline.. On 16/11/18 21:27, Bernd Eckenfels wrote: Hello Sean, I was only looking a

Re: downport of JDK-8209965 / JDK-8210005

2018-11-21 Thread Rob McKenna
..11.0.3-oracle represents the Oracle JDK release scheduled for April 2019 as you correctly note. -Rob On 21/11/18 16:13, Rob McKenna wrote: > Hi Goetz, > > The CPUXX_YY-critical-request indicates that the engineer is attempting > to get this fix approved for inclusion in 11.0.2. This may or

Re: downport of JDK-8209965 / JDK-8210005

2018-11-21 Thread Rob McKenna
Hi Goetz, The CPUXX_YY-critical-request indicates that the engineer is attempting to get this fix approved for inclusion in 11.0.2. This may or may not be successful (though the SQE-OK label indicates it has overcome one of the bigger hurdles) If approval is secured the fix will be pushed to the s

Re: RFR: 8213952: Relax DNSName restriction as per RFC 1123

2018-11-21 Thread Seán Coffey
Thanks for the comments Bernd. Comments inline.. On 16/11/18 21:27, Bernd Eckenfels wrote: Hello Sean, I was only looking at the inspected DNSName class, it still has some variations (but start now with DNSNames which is good already): 76 throw new IOException("DNSName must not be null or

RFR 8214179: Add groupname info into keytool -list and -genkeypair output

2018-11-21 Thread Weijun Wang
Please take a review at https://cr.openjdk.java.net/~weijun/8214179/webrev.00/ Before this change, `keytool -genkeypair -keyalg EC -groupname brainpoolP256r1` shows Generating -1 bit EC key pair and self-signed certificate... With this change, the message becomes Generating brainpoolP25

RE: downport of JDK-8209965 / JDK-8210005

2018-11-21 Thread Lindenmaier, Goetz
Hi, thanks for working on this issue! But I'm not clear what it means that you did. Do I understand correctly that tag CPU19_01-critical-SQE-OK in 8209965 means it will be fixed in the January 2019 release of jdk11? I.e., the change will show up on January 15th 2019 in the open repository jdk-