* DNSName.java:
91 if ((endIndex - startIndex) < 1)
No need for inner parentheses.
And, is there really a need to define alphaDigitsAndHyphen? How about just (==
'-' || inside alphaDigits)?
* DNSNameTest.java:
Space cannot appear anywhere, please add a test case like "a c.com".
> On Nov 22, 2018, at 9:14 AM, Valerie Peng wrote:
>
> Hi Max,
>
> Here are some comments:
>
>
> - line 39, add PSS here as well.
> - line 97, CSignature ctr, better to initialize all fields
Which particular ones are you thinking about? privateKey and publicKey will be
initialized later a
Please take a review at
https://cr.openjdk.java.net/~weijun/8214100/webrev.00/
Some exception handling codes are added to keytool when the keystore type does
not support probing.
Thanks
Max
