Thanks for your review Max. I've made the suggested edits.
http://cr.openjdk.java.net/~coffeys/webrev.8213952.v3/webrev/
I've also submitted a CSR for this change just to cover the behavioural
aspect of the edit. Will push if/once that's approved by CSR team.
Regards,
Sean.
On 22/11/18
I was curious in some SunEC internals and turned EC_DEBUG on, and found out the
library cannot be built. It looks like back when we switched to
warnings-as-errors some codes are not updated. Here is the patch:
diff --git a/src/jdk.crypto.ec/share/native/libsunec/impl/ec.c