Looks good. My only question is whether the apiNote should be an
implNote instead since it refers to what the JDK Implementation does.
But either way seems ok.
--Sean
On 11/26/18 1:14 PM, Xue-Lei Fan wrote:
I made the update accordingly:
http://cr.openjdk.java.net/~xuelei/8210985/webrev.0
Looks fine Joe
I hadn't realized example.com was registered for that purpose. :)
On 11/26/2018 04:38 PM, joe darcy wrote:
Hello,
Please review a simple doc-only change to address:
JDK-8213911: Use example.com in java.net and other examples
http://cr.openjdk.java.net/~darcy/8213911.0
Thanks for the feedback Max. I'll ping Joe Darcy and check if a CSR is
required for this type of change. I'll revert back to this list once I
have an answer.
keytool works well with the new change. I've modified the test as per
your suggestion :
--- a/test/jdk/sun/security/tools/keytool/KeyT
> On Nov 27, 2018, at 9:55 AM, Valerie Peng wrote:
>
> Hi Max,
>
> Please find comments in line.
> On 11/22/2018 6:04 AM, Weijun Wang wrote:
>>> On Nov 22, 2018, at 9:14 AM, Valerie Peng
>>> wrote:
>>>
>>> Hi Max,
>>>
>>> Here are some comments:
>>>
>>>
>>> - line 39, add PSS here as we
Looks ok to me.
-Chris.
On 26/11/2018 21:38, joe darcy wrote:
Hello,
Please review a simple doc-only change to address:
JDK-8213911: Use example.com in java.net and other examples
http://cr.openjdk.java.net/~darcy/8213911.0/
Patch below.
Thanks,
-Joe
--- old/src/java.base/share
Looks fine to me.
--Sean
On 11/26/18 4:38 PM, joe darcy wrote:
Hello,
Please review a simple doc-only change to address:
JDK-8213911: Use example.com in java.net and other examples
http://cr.openjdk.java.net/~darcy/8213911.0/
Patch below.
Thanks,
-Joe
--- old/src/java.base/shar
On 11/27/18 7:36 AM, Baesken, Matthias wrote:
Hi Sean , maybe I was not clear enough - when I said " but we only see the
issue since last week"I meant we started to see the issue in our local jtreg
test runs
for jdk11u and for jdk/jdk .
Oh, I see. I have not looked at this
Hi Sean , maybe I was not clear enough - when I said " but we only see
the issue since last week"I meant we started to see the issue in our
local jtreg test runs
for jdk11u and for jdk/jdk .
Do you think
security/infra/java/security/cert/CertPathValidator/certification/Actal
