RFR[12] JDK-8214520: [TEST_BUG] sun/security/mscapi/nonUniqueAliases/NonUniqueAliases.java failed with incorrect jtreg tags order

2018-12-11 Thread sha . jiang
Hi, When run this test on Windows, jtreg complains that '@library' must appear before first action tag. So, just adjust the tag positions. Issue: https://bugs.openjdk.java.net/browse/JDK-8214520 diff -r a6182c464b31 test/jdk/sun/security/mscapi/nonUniqueAliases/NonUniqueAliases.java --- a/te

Re: RFR 8213010: [cng] Supporting keys created with certmgr.exe

2018-12-11 Thread Weijun Wang
Hi Valerie, > On Dec 12, 2018, at 6:21 AM, Valerie Peng wrote: > > Hi Max, > > > > - Comments (line 60-63) missed SHA224withECDSA? Oops. > > - Line 430: should be "ECPublicKey" Oops again. > > - Line 919, 922: is it really necessary to have two methods with algorithm > name argument? I

Re: RFR 6722928: Support SSPI as a native GSS-API provider

2018-12-11 Thread Nico Williams
My review of the first 16% of https://cr.openjdk.java.net/~weijun/6722928/webrev.02/ is below. - First, I noticed this in the gssapi.h in the JDK: typedef void * gss_name_t; typedef void * gss_cred_id_t; typedef void * gss_ctx_id_t; This is not good! We long ago discovered th

Re: RFR 8213010: [cng] Supporting keys created with certmgr.exe

2018-12-11 Thread Valerie Peng
Hi Max, - Comments (line 60-63) missed SHA224withECDSA? - Line 430: should be "ECPublicKey" - Line 919, 922: is it really necessary to have two methods with algorithm name argument? It seems they are functionally the same but one calls CAPI vs CNG. Can they be merged? - generateECBlob()

Re: RFR: 8211752: JNU_ThrowIOExceptionWithLastErrorAndPath - enhance some IOExceptions with path causing the issue

2018-12-11 Thread Sean Mullan
On 12/11/18 10:38 AM, Baesken, Matthias wrote: File paths are, in general, always something that demands extra scrutiny as it can be the source of security issues (privacy leaks, traversal attacks, etc). It's not just me that thinks that way, you can do a search on the Internet and find lots of r

Re: JDK11 Bug with SSLv3

2018-12-11 Thread Jamil Nimeh
Quick follow up.  Thomas and I exchanged a couple messages off-alias but I wanted to summarize it here in case others were following this thread.  The short story: Based on what is in RFC 5246 with respect to the RSA client key exchange message, the Java client is putting the correct version in

RE: RFR: 8211752: JNU_ThrowIOExceptionWithLastErrorAndPath - enhance some IOExceptions with path causing the issue

2018-12-11 Thread Baesken, Matthias
> File paths are, in general, always something that demands extra scrutiny > as it can be the source of security issues (privacy leaks, traversal > attacks, etc). It's not just me that thinks that way, you can do a > search on the Internet and find lots of references. ... > > It might be perfectly

Re: java.lang.Error is swallowed by LoginContext#invoke

2018-12-11 Thread Weijun Wang
Does -Djava.security.debug=logincontext show anything? This is the formal way to debug JAAS. Also, you can put debug=true in your Krb5LoginModule config entry and see what's happening, and there is always -Dsun.security.krb5.debug=true to show kerberos related debug info. --Max > On Dec 11, 2

java.lang.Error is swallowed by LoginContext#invoke

2018-12-11 Thread Wenxiang
Hi everyone, I was using Hadoop command line interface to access HDFS with a non-root user. After successfully running kinit, Hadoop FsShell fails with GSSException: No valid credentials provided (Mechanism level: Failed to find any Kerberos tgt). After using a subclassed Krb5LoginModule to pr