On 19/12/2018 3:19 am, Baesken, Matthias wrote:
Hello, here is an updated webrev :
http://cr.openjdk.java.net/~mbaesken/webrevs/8215411.1/
sawindbg.cpp has been adjusted .
The exception cases mentioned now also call env->ReleaseByteArrayElements .
Looks good - thanks.
One minor styl
> On Dec 19, 2018, at 7:24 AM, Valerie Peng wrote:
>
> Thanks Sean and Max for the review.
>
> I have updated the webrev with Max's comment regarding line 87 and 100.
>
> http://cr.openjdk.java.net/~valeriep/8214096/webrev.01/
Looks fine to me.
>
> Will proceed with integration once the m
Thanks Sean and Max for the review.
I have updated the webrev with Max's comment regarding line 87 and 100.
http://cr.openjdk.java.net/~valeriep/8214096/webrev.01/
Will proceed with integration once the mach5 job is done.
As for calling setParameter(...) with null value, people may have
diffe
On 19/12/2018 6:52 am, dean.l...@oracle.com wrote:
David, can I list you as a reviewer?
No, sorry, I only commented on the general issue.
David
dl
On 12/16/18 8:47 PM, dean.l...@oracle.com wrote:
On 12/16/18 7:39 PM, dean.l...@oracle.com wrote:
On 12/16/18 7:03 PM, David Holmes wrote:
On
Claes, can I list you as a reviewer?
dl
On 12/16/18 9:52 PM, Claes Redestad wrote:
Fair enough, I wasn't aware EA was looking beyond the inlined code like
this (which means it can't be "dead" or the JIT might see through the
trick at some point). I've skimmed the existing usages in the JDK and
David, can I list you as a reviewer?
dl
On 12/16/18 8:47 PM, dean.l...@oracle.com wrote:
On 12/16/18 7:39 PM, dean.l...@oracle.com wrote:
On 12/16/18 7:03 PM, David Holmes wrote:
On 17/12/2018 12:49 pm, dean.l...@oracle.com wrote:
On 12/16/18 4:06 PM, David Holmes wrote:
On 15/12/2018 10:59
Hi Dean,
this looks good to me.
Best regards,
Tobias
On 17.12.18 23:49, dean.l...@oracle.com wrote:
> https://bugs.openjdk.java.net/browse/JDK-8214329
> http://cr.openjdk.java.net/~dlong/8214329/webrev/
>
> In "8212605: Pure-Java implementation of AccessController.doPrivileged", the
> stackwal
On 12/18/18 2:00 PM, Sean Mullan wrote:
On 12/18/18 11:33 AM, dean.l...@oracle.com wrote:
Also, the bug says it is BlockedBy JDK-8215205 which should probably
be removed.
That's because JDK-8215205 hasn't been pushed yet.
Ok, but isn't BlockedBy supposed to mean you can't fix this issue un
On 12/18/18 11:33 AM, dean.l...@oracle.com wrote:
Also, the bug says it is BlockedBy JDK-8215205 which should probably
be removed.
That's because JDK-8215205 hasn't been pushed yet.
Ok, but isn't BlockedBy supposed to mean you can't fix this issue until
the one that it is blocked by is fix
On 12/17/18 5:26 PM, Xue-Lei Fan wrote:
On 12/17/2018 1:17 PM, Anthony Scarpino wrote:
It looks like in TransportContext.java:68, you had a mistype that
added "fa" to the end of a comment.
Oops, I will update it.
Also in fatal():267, did you plan to return the exception and have the
calling
Hello, here is an updated webrev :
http://cr.openjdk.java.net/~mbaesken/webrevs/8215411.1/
sawindbg.cpp has been adjusted .
The exception cases mentioned now also call env->ReleaseByteArrayElements .
Best regards, Matthias
> -Original Message-
> From: David Holmes
> Sent: Die
On 12/18/18 7:12 AM, Sean Mullan wrote:
Looks good, although I think someone from the HotSpot Group should
also review it.
Thanks Sean. Tobias reviewed it.
On the bug, can you add the details below into the Description?
Sure.
Also, since you have no regression test, you will need a nore
Thanks Tobias.
dl
On 12/18/18 4:08 AM, Tobias Hartmann wrote:
Hi Dean,
this looks good to me.
Best regards,
Tobias
On 17.12.18 23:49, dean.l...@oracle.com wrote:
https://bugs.openjdk.java.net/browse/JDK-8214329
http://cr.openjdk.java.net/~dlong/8214329/webrev/
In "8212605: Pure-Java implem
Looks good, although I think someone from the HotSpot Group should also
review it.
On the bug, can you add the details below into the Description? Also,
since you have no regression test, you will need a noreg label (I guess
noreg-perf would be appropriate). Also, the bug says it is BlockedBy
> On Dec 18, 2018, at 9:14 PM, Sean Mullan wrote:
>
> On 12/17/18 10:14 PM, Weijun Wang wrote:
>> Hi Valerie,
>> Please put lines 87 and 100 into the if-not-null block. Otherwise fine.
>> Do you think we can enhance the Signature::setParameter method and claim a
>> null parameter is not meani
On 12/17/18 10:14 PM, Weijun Wang wrote:
Hi Valerie,
Please put lines 87 and 100 into the if-not-null block. Otherwise fine.
Do you think we can enhance the Signature::setParameter method and claim a null
parameter is not meaningful at all and should not have any effect on the
internal state
Looks good.
--Sean
On 12/17/18 7:41 PM, Valerie Peng wrote:
Any one has time to review this straightforward fix? Details on cause
and fix is elaborated in the link below:
Bug: https://bugs.openjdk.java.net/browse/JDK-8214096
Webrev can be found at
http://cr.openjdk.java.net/~valeriep/821409
Update the copyright date. Otherwise looks fine.
--Sean
On 12/18/18 2:21 AM, Alan Bateman wrote:
This looks okay to me
(cc'ing security-dev as that is where the smart card I/O API is maintained)
On 18/12/2018 05:23, Priya Lakshmi Muthuswamy wrote:
Hi,
Kindly review the changes for
https:/
> On Dec 15, 2018, at 5:09 AM, Sean Mullan wrote:
>
> On 12/12/18 10:57 AM, Weijun Wang wrote:
>> Thanks. Will you please also take a look at the release note
>> athttps://bugs.openjdk.java.net/browse/JDK-8215293?
>
> I'm not sure about including the second sentence: "In particular, the
> a
Hi Matthias,
On 18/12/2018 6:52 pm, Baesken, Matthias wrote:
Hi JC / David, thanks for the input .
I'm not really sure what you want me to change David, am I right that I can
keep the changes to
src/java.base/macosx/native/libosxsecurity/KeystoreImpl.m
src/jdk.attach/windows/native/liba
Hi JC / David, thanks for the input .
I'm not really sure what you want me to change David, am I right that I can
keep the changes to
src/java.base/macosx/native/libosxsecurity/KeystoreImpl.m
src/jdk.attach/windows/native/libattach/VirtualMachineImpl.c
but adjust
src/jdk.hotspot.agent
21 matches
Mail list logo
