TLSv1.3 HttpsServer endless loop based on client socket i/o shutdown

2019-02-08 Thread Jay Modi
Hi, I've been doing some testing with Apache HttpClient against the com.sun.net.httpserver.HttpsServer that is included with the JDK and came across some interesting behavior that occurs when using TLSv1.3, but TLSv1.2 works normally. If the client manually calls Socket#shutdownOutput and Socket#s

RFR 8168069 : X509TrustManagerImpl causes ClassLoader leaks with unparseable extensions

2019-02-08 Thread Xuelei Fan
Hi, Could I get the following update reviewed? http://cr.openjdk.java.net/~xuelei/8168069/webrev.00/ In the lazy initialization holder in SSLContextImpl, an exception is reserved as static in order to check if the holder is initialized properly. If the exception had a strong referent to so

Re: RFR 8180569: Refactor sun/security/krb5/ shell tests to plain java tests

2019-02-08 Thread Sean Mullan
Looks good to me. --Sean On 2/3/19 9:44 AM, Weijun Wang wrote: Please take a review at https://cr.openjdk.java.net/~weijun/8180569/webrev.00 I've combined ktarg.sh, ktmissing.sh, and ktzero.sh into KtabZero.java. rcache_usemd5.sh is renamed to ReplayCacheTestProcWithMD5.java. The test ha

Re: Code Review Request, JDK-8218580, endpoint identification algorithm should be case-insensitive

2019-02-08 Thread Jamil Nimeh
Looks fine to me. --Jamil On 2/8/2019 8:16 AM, Xuelei Fan wrote: Hi, Please review this update:    http://cr.openjdk.java.net/~xuelei/8218580/webrev.00/ Objects.equals is case-sensitive, and should not be used to recognize case-insensitive objects. Trivial update, no new regression test.

Code Review Request, JDK-8218580, endpoint identification algorithm should be case-insensitive

2019-02-08 Thread Xuelei Fan
Hi, Please review this update: http://cr.openjdk.java.net/~xuelei/8218580/webrev.00/ Objects.equals is case-sensitive, and should not be used to recognize case-insensitive objects. Trivial update, no new regression test. Thanks, Xuelei