Re: RFR [13] 8217878: ENVELOPING XML signature no longer works in JDK 11

2019-03-04 Thread Weijun Wang
Everything is fine now. Thanks, Max > On Mar 5, 2019, at 4:11 AM, Sean Mullan wrote: > > Updated webrev: http://cr.openjdk.java.net/~mullan/webrevs/8217878/webrev.01/ > > Changes: > > - Added DOMCryptoBinary.java > - Changed Base64 calls to XMLUtils in DOMKeyValue, DOMPGPData,

RFR 8157404: Unable to read certain PKCS12 keystores from SequenceInputStream

2019-03-04 Thread Weijun Wang
Please take a review at https://cr.openjdk.java.net/~weijun/8157404/webrev.00/ When Java finds out data is not enough while resolving a BER, it reads in more data and try converting again. Please note that calling available() again after readNBytes is not reliable because it might return

Re: RFR 8180573: Refactor sun/security/tools shell tests to plain java tests

2019-03-04 Thread Weijun Wang
Webrev updated at https://cr.openjdk.java.net/~weijun/8180573/webrev.01 BTW, last time I mistakenly removed ExportPrivateKeyNoPwd.java which is used by ListKeychainStore.sh. It's now back. Thanks, Max > On Feb 15, 2019, at 9:31 PM, Weijun Wang wrote: > > Hi Philipp, > > In most cases,

Re: SSLEngine.wrap(...) returns NOT_HANDSHAKING even when the alert was not consumed yet in latest JDK12 release (possible regression).

2019-03-04 Thread Norman Maurer
Any comments here ? Bye Norman > On 28. Feb 2019, at 09:24, Norman Maurer wrote: > > Hi all, > > I think I found a possible regression / bug in the latest JDK12 release when > trying to upgrade the Netty CI server to test with the latest JDK12 release. > The problem is that

Re: RFR [13] 8217878: ENVELOPING XML signature no longer works in JDK 11

2019-03-04 Thread Sean Mullan
Updated webrev: http://cr.openjdk.java.net/~mullan/webrevs/8217878/webrev.01/ Changes: - Added DOMCryptoBinary.java - Changed Base64 calls to XMLUtils in DOMKeyValue, DOMPGPData, DOMReference, DOMSignedInfo, DOMX509Data, and DOMXMLSignature Thanks, Sean On 3/4/19 8:33 AM, Sean Mullan

RFR 8147502: Digest is incorrectly truncated for ECDSA signatures...

2019-03-04 Thread Adam Petcher
webrev: https://cr.openjdk.java.net/~apetcher/8147502/webrev.00/ JBS: https://bugs.openjdk.java.net/browse/JDK-8147502 Please review this fix to a bug that causes ECDSA signatures to be incorrect in some cases. The fix is simple, but testing this issue is difficult because the API doesn't give

Re: RFR [13] 8217878: ENVELOPING XML signature no longer works in JDK 11

2019-03-04 Thread Sean Mullan
On 3/3/19 10:32 PM, Weijun Wang wrote: Two questions: 1. There is no DOMCryptoBinary.java. Maybe you forgot "hg add"? Yes, I did. I will add it. 2. The Base64 class is called directly in several places. Aren't the helper methods in XMLUtils enough? Good catch, since that code is not