Good catch! I missed the update for SignatureScheme.
Here is the new webrev:
http://cr.openjdk.java.net/~xuelei/8217610/webrev.01/
Thanks,
Xuelei
On 4/2/2019 12:35 PM, Valerie Peng wrote:
Hmm, I didn't see the SignatureScheme.java in the webrev? The stacktrace
in the bug record shows the
Hi,
Could I get the following update reviewed?
http://cr.openjdk.java.net/~xuelei/8221882/webrev.00/
To benefits from with Fibers [1], there is a need to use explicit locks,
java.util.concurrent.locks, for synchronization in JSSE and the SunJSSE
provider.
Most of the update is replacing
Thank you Weijun!
On 4/2/19 5:46 PM, Weijun Wang wrote:
Hi Ivan,
Code change looks fine to me. The system property is also new to me and it saved a lot of
"../../..".
Thanks,
Max
On Apr 3, 2019, at 5:52 AM, Ivan Gerasimov wrote:
Hello!
I'm seeking to backport the fix to 12u, and the cor
Hi Ivan,
Code change looks fine to me. The system property is also new to me and it
saved a lot of "../../..".
Thanks,
Max
> On Apr 3, 2019, at 5:52 AM, Ivan Gerasimov wrote:
>
> Hello!
>
> I'm seeking to backport the fix to 12u, and the corresponding regression test
> had to be slightly ed
Hi Sean,
On 2/04/2019 10:47 pm, Sean Mullan wrote:
Hi David,
These tests still seem somewhat VM-specific to me. We don't have any
*.jasm files in our tests area. Are these tests even relevant anymore
now that doPriv is all-Java? The previous bug fix that introduced these
tests was entirely i
Hello!
I'm seeking to backport the fix to 12u, and the corresponding regression
test had to be slightly edited.
Turns out that Mach5 runs jtreg4.2-b13 for 12u builds, and that version
does not support "test.root" system property.
The modification is straight-forward.
WEBREV: http://cr.open
Hmm, I didn't see the SignatureScheme.java in the webrev? The stacktrace
in the bug record shows the casting being inside SignatureScheme class.
Did I miss something?
Valerie
On 3/28/2019 7:52 AM, Xuelei Fan wrote:
ping ...
Xuelei
On 3/22/2019 2:02 PM, Xuelei Fan wrote:
Hi,
Could I get
Thank you, Alan
Vladimir
On 4/1/19 11:56 PM, Alan Bateman wrote:
On 01/04/2019 22:44, Vladimir Kozlov wrote:
https://bugs.openjdk.java.net/browse/JDK-8221782
Recent 'Update Graal' JDK-8221341 added import jdk.vm.ci.services.Services
class to HotSpotGraalRuntimeMBean.java.
JVMCI module-info.j
Thank you, Sean
I added link to bug report as you suggested.
Vladimir
On 4/2/19 5:54 AM, Sean Mullan wrote:
Looks good. For future reference, can you add a link to the bug (8221341) that
introduced this regression?
--Sean
On 4/1/19 5:44 PM, Vladimir Kozlov wrote:
https://bugs.openjdk.java.
+1.
--Max
> On Apr 2, 2019, at 9:55 PM, Roger Riggs wrote:
>
> Hi Sean,
>
> Typically, fixed serialization streams are encoded in the source
> as byte arrays. That keeps binary content out of the repo
> and provides a place for the comments.
>
> Roger
>
>
> On 04/02/2019 09:50 AM, Sean Mull
Hi Sean,
Typically, fixed serialization streams are encoded in the source
as byte arrays. That keeps binary content out of the repo
and provides a place for the comments.
Roger
On 04/02/2019 09:50 AM, Sean Mullan wrote:
On 4/2/19 9:44 AM, Weijun Wang wrote:
On Apr 2, 2019, at 9:33 PM, Sea
On 4/2/19 9:44 AM, Weijun Wang wrote:
On Apr 2, 2019, at 9:33 PM, Sean Mullan wrote:
On 4/1/19 11:12 PM, Weijun Wang wrote:
I can understand the change in Permissions, but is there any difference in
PermissionsHash?
The key and value in the PermissionsHash map is always the same object.
> On Apr 2, 2019, at 9:33 PM, Sean Mullan wrote:
>
> On 4/1/19 11:12 PM, Weijun Wang wrote:
>> I can understand the change in Permissions, but is there any difference in
>> PermissionsHash?
>
> The key and value in the PermissionsHash map is always the same object. This
> fix ensures that i
On 4/1/19 11:12 PM, Weijun Wang wrote:
I can understand the change in Permissions, but is there any difference in
PermissionsHash?
The key and value in the PermissionsHash map is always the same object.
This fix ensures that is respected, otherwise after deserialization you
could have a Sock
Looks good. For future reference, can you add a link to the bug
(8221341) that introduced this regression?
--Sean
On 4/1/19 5:44 PM, Vladimir Kozlov wrote:
https://bugs.openjdk.java.net/browse/JDK-8221782
Recent 'Update Graal' JDK-8221341 added import
jdk.vm.ci.services.Services class to Hot
Hi David,
These tests still seem somewhat VM-specific to me. We don't have any
*.jasm files in our tests area. Are these tests even relevant anymore
now that doPriv is all-Java? The previous bug fix that introduced these
tests was entirely in the hotspot code and had to do with default
method
On 01/04/2019 22:44, Vladimir Kozlov wrote:
https://bugs.openjdk.java.net/browse/JDK-8221782
Recent 'Update Graal' JDK-8221341 added import
jdk.vm.ci.services.Services class to HotSpotGraalRuntimeMBean.java.
JVMCI module-info.java was updated accordingly [1] but
src/java.base/share/lib/securit
17 matches
Mail list logo
