Webrev updated at
https://cr.openjdk.java.net/~weijun/8219861/webrev.02
The "Disabled by Default" lists are removed. They could be a little confused.
Thanks,
Max
> On Apr 4, 2019, at 4:25 AM, Sean Mullan wrote:
>
> On 3/28/19 8:20 AM, Weijun Wang wrote:
>> Please take a review at
>>
On 3/28/19 8:20 AM, Weijun Wang wrote:
Please take a review at
https://cr.openjdk.java.net/~weijun/8219861/webrev.01/
The ShowInfo::tls method is extracted from the JSSE Provider doc [1].
Noreg-other?
Seems ok, unless you want to add a test which adds or removes a suite
from the
Changes look fine~
Thanks,
Valerie
On 4/2/2019 8:45 PM, Xuelei Fan wrote:
Good catch! I missed the update for SignatureScheme.
Here is the new webrev:
http://cr.openjdk.java.net/~xuelei/8217610/webrev.01/
Thanks,
Xuelei
On 4/2/2019 12:35 PM, Valerie Peng wrote:
Hmm, I didn't see the
On 4/3/2019 12:06 PM, Alan Bateman wrote:
On 03/04/2019 19:40, Xuelei Fan wrote:
Updated webrev (updated SSLContext.java, HttpsClient,
HttpsURLConnectionImpl):
http://cr.openjdk.java.net/~xuelei/8221882/webrev.01/
This looks good to me, the only change that I'm not 100% sure on is in
On 03/04/2019 19:40, Xuelei Fan wrote:
Updated webrev (updated SSLContext.java, HttpsClient,
HttpsURLConnectionImpl):
http://cr.openjdk.java.net/~xuelei/8221882/webrev.01/
This looks good to me, the only change that I'm not 100% sure on is in
HttpsClient where the locking will not be
On 4/3/2019 2:32 AM, Bernd Eckenfels wrote:
Hello,
There are a few places where a synchronized method is freed up w/o new
lock, which is generally a good thing but I wonder if there is a
justification available why it is no problem (DTLSInputRecord vs.
DTLSOutputRecord).
For
Updated webrev (updated SSLContext.java, HttpsClient,
HttpsURLConnectionImpl):
http://cr.openjdk.java.net/~xuelei/8221882/webrev.01/
On 4/3/2019 1:03 AM, Alan Bateman wrote:
On 03/04/2019 04:12, Xuelei Fan wrote:
Hi,
Could I get the following update reviewed?
Hello,
There are a few places where a synchronized method is freed up w/o new lock,
which is generally a good thing but I wonder if there is a justification
available why it is no problem (DTLSInputRecord vs. DTLSOutputRecord).
Is the DCL In EphemeralKepair Safe, I am not sure how arrays and
On 03/04/2019 04:12, Xuelei Fan wrote:
Hi,
Could I get the following update reviewed?
http://cr.openjdk.java.net/~xuelei/8221882/webrev.00/
To benefits from with Fibers [1], there is a need to use explicit
locks, java.util.concurrent.locks, for synchronization in JSSE and the
SunJSSE
